GNOME Bugzilla – Bug 653323
librsvg-2.34.0 rdepends on gtk+-3 automagically
Last modified: 2017-12-13 17:48:17 UTC
Created attachment 190569 [details] [review] 1.patch As reported downstream at: http://bugs.gentoo.org/show_bug.cgi?id=371290 librsvg automagically depends on gtk+-3 when it's present in the system, we would like to be able to set what gtk+ to use with "--with-gtk=2.0|3.0|all" switch. Our doubts are about how to properly handle building supporting both versions when user wants to. Attached patch could be a start point, but would be nice to get upstream suggestions also. Thanks a lot
Any news here? Thanks
Created attachment 211889 [details] [review] proposed patch for 2.36.0 A similar issue exists in librsvg-2.36.0: rsvg-view-3 is always built if gtk3 is detected; there is no way to explicitly disable rsvg-view-3 when creating a package for a gtk2-only deployment when using a build machine that has gtk3 installed. The attached patch adds a --disable-rsvg-view configure switch to do so. Please review.
I don't see why this is necessary. If you have gtk3-devel pkg installed, it builds rsvg-view; but you can just simply not put that into your package and thus avoid the gtk3 dep on it...
Hi. I'm coming back to this old bug. I think it's be worth doing what gentoo does and making the compilation of rsvg-view optional with a configure switch. Sure, one does not have to include it in the package; but when running package bulk builds, packages are often added/removed and in the case of librsvg the following happens quite often for me: * librsvg is schedule to build * gtk+3 is detected at configure time * while librsvg is being built, the gtk+3 package may end up being removed because it is not registered as a dependency * librsvg build fails because it detected gtk+3 at configure time but it got removed in the middle of the librsvg compilation Sure I can enforce a build-only dependency on gtk+3 for librsvg but this seems overkill. I don't think it costs much to add this configure check, preserving the default behavior of if gtk+3 is found, then build rsvg-view. As far as I am concerned, it would means less local patches for me... FWIW.
(In reply to comment #3) > I don't see why this is necessary. If you have gtk3-devel pkg installed, it > builds rsvg-view; but you can just simply not put that into your package and > thus avoid the gtk3 dep on it... Hi Christian. Would it be really an issue to have this patch committed? That would at least help OpenBSD and Gentoo maintainers... I can push it, but since you had some reservations. Thank you.
*** Bug 396722 has been marked as a duplicate of this bug. ***
*** Bug 712693 has been marked as a duplicate of this bug. ***
There's another patch proposed in duplicate bug 712693.
can this patch be finally pushed? https://bugzilla.gnome.org/show_bug.cgi?id=712693#c3
Seriously, why isn't this patch included? Several distributions have user repositories for source packages, creating binary packages locally. Having the header files installed does not necessarily mean that the libraries (for the current architecture) are also installed. (like when building 32 bit packages, having gtk3 installed, but no 32 bit gtk3) Current issue at the lib32 package for Arch Linux User Repository (AUR): https://aur.archlinux.org/packages/lib32-librsvg/
ping
Please, take a look on this if possible
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/librsvg/issues/53.