After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653268 - build fix
build fix
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-23 19:06 UTC by Patrick Welche
Modified: 2011-07-01 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to g/c HAVE_INTROSPECTION (1.05 KB, patch)
2011-06-23 19:06 UTC, Patrick Welche 		none Details | Review

Description Patrick Welche 2011-06-23 19:06:15 UTC 
Created attachment 190529 [details] [review]
patch to g/c HAVE_INTROSPECTION

HAVE_INTROSPECTION is not defined - patch self-explanatory ;-)
Comment 1 Vincent Untz 2011-06-27 19:09:53 UTC 
HAVE_INTROSPECTION should get defined with the GOBJECT_INTROSPECTION_CHECK macro in configure, so the patch doesn't seem correct to me.
Comment 2 Patrick Welche 2011-06-28 13:30:38 UTC 
From the patch:

"Given the contents of libcaribou_la_VALAFLAGS, introspection isn't optional."

AFAICT "--gir _Caribou-1.0.gir" in caribou/libcaribou/Makefile.am won't work unless you have introspection.

In caribou/configure.ac, there is:
GOBJECT_INTROSPECTION_CHECK([0.10.7])

so, maybe that should be changed to GOBJECT_INTROSPECTION_REQUIRE([0.10.7]) as well as removing the HAVE_INTROSPECTION ?

(I'm not near the relevant test computer at the moment...)
Comment 3 Eitan Isaacson 2011-07-01 18:42:09 UTC 
(In reply to comment #2)
> From the patch:
> 
> "Given the contents of libcaribou_la_VALAFLAGS, introspection isn't optional."
> 
> AFAICT "--gir _Caribou-1.0.gir" in caribou/libcaribou/Makefile.am won't work
> unless you have introspection.
> 

It should work, since the gir is generated via valac and not GI.

> In caribou/configure.ac, there is:
> GOBJECT_INTROSPECTION_CHECK([0.10.7])
> 
> so, maybe that should be changed to GOBJECT_INTROSPECTION_REQUIRE([0.10.7]) as
> well as removing the HAVE_INTROSPECTION ?
> 

That seems correct :)

Since libcaribou is pretty much useless without GI.

Fixed in master.