Created attachment 190516 [details] [review]
patch

Review of attachment 190516 [details] [review]:

One minor comment, otherwise looks fine.

::: glib/gregex.c
@@ +623,3 @@
+ * to zero, it frees all the memory associated with the match_info structure.
+ *
+ * Since: 2.14

Consider deprecating _free() in favor of _unref() ?  You could change the doc comment to point to there too instead of duplicating it.

I thought about deprecating _free(), but I'd feel a bit bad to impose extra code churn on its users just for basically renaming a function... Also, _free() is NULL-safe (not sure that's actually used anywhere, but since it was, I kept it that way), and a NULL-safe _unref() would be weird.

(In reply to comment #3)
> I thought about deprecating _free(), but I'd feel a bit bad to impose extra
> code churn on its users just for basically renaming a function... Also, _free()
> is NULL-safe (not sure that's actually used anywhere, but since it was, I kept
> it that way), and a NULL-safe _unref() would be weird.

Ok, fair enough; just raising the question.  Feel free to commit then!

Pushed to master after changing the docs to _free() to point to _unref(). Thanks for the quick review and approval!