After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653247 - Don't show TIFF documents inline
Don't show TIFF documents inline
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on: 335959
Blocks:
 
 
Reported: 2011-06-23 16:19 UTC by David Richards
Modified: 2011-06-30 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Trivial patch (1.08 KB, patch)
2011-06-30 13:15 UTC, Matthew Barnes
none Details | Review
Multi page TIFF sample (101.22 KB, image/tiff)
2011-06-30 14:33 UTC, David Richards
  Details

Description David Richards 2011-06-23 16:19:00 UTC
When users receive multi-page TIFF documents in Evolution, it allows you to view the document Inline...however when doing so it only displays the first page and in no way indicates that more pages might exist.

Evolution should either:

1) Display all pages

-or-

2) Make no attempt to display Inline and require them to use an external reader.
Comment 1 Matthew Barnes 2011-06-23 16:25:05 UTC
Can you attach a sample?

We rely on GdkPixbuf to handle image formats, so I'm wondering if GDK's TIFF backend is programmed to only render the first page.  Just a wild guess.  Perhaps the page count is embedded as GdkPixbuf metadata such that we could check it before showing the first page inline.
Comment 2 Matthew Barnes 2011-06-23 16:33:54 UTC
I think my guess was correct, see bug 335959.

Our hands are kinda tied until that's fixed.
Comment 3 Matthew Barnes 2011-06-30 13:15:07 UTC
Created attachment 191022 [details] [review]
Trivial patch

Easy enough to fix, but I'd still like a sample multi-page TIFF image so I can reproduce the issue and verify that other apps can handle it correctly.
Comment 4 David Richards 2011-06-30 14:33:57 UTC
Created attachment 191032 [details]
Multi page TIFF sample
Comment 5 Matthew Barnes 2011-06-30 15:13:47 UTC
Perfect, thanks!  Looks like Evince and Gimp can handle them correctly.

Fixed for Evolution 3.1.3 and 3.0.3:

http://git.gnome.org/browse/evolution/commit/?id=75ec784e5d33162a675bb2721f4bafae0a0b7227

http://git.gnome.org/browse/evolution/commit/?h=gnome-3-0&id=d4b1b564e33c0166fcf13be580f9be6174658a4a