After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653245 - Don't ship pre-generated .gir files in dist tarball
Don't ship pre-generated .gir files in dist tarball
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.28.x
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-23 15:59 UTC by Michael Biebl
Modified: 2011-10-19 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Biebl 2011-06-23 15:59:49 UTC 
The 1.28.4 release ships pre-generated .gir files in the dist tarball:

ls pango/*.gir
pango/Pango-1.0.gir  pango/PangoCairo-1.0.gir  pango/PangoFT2-1.0.gir  pango/PangoXft-1.0.gir

This causes problems if you build with builddir != srcdir, as the the .gir files from srcdir are used  on "make install", and those files are possibliy outdated.

E.g. in Debian we use repository format 1.2, whereas the pre-generated .gir files use 1.1.

Please don't distribute the .gir files in the dist tarball.


[1] http://ftp.gnome.org/pub/GNOME/sources/pango/1.28/pango-1.28.4.tar.gz
Comment 1 Michael Biebl 2011-06-23 16:01:41 UTC 
(In reply to comment #0)
> 
> E.g. in Debian we use repository format 1.2, whereas the pre-generated .gir
> files use 1.1.

This is the error message when I try to build pango 1.28.4 on Debian with srcdir!=builddir:

make[4]: Entering directory `/home/michael/debian/build-area/pango-1.28.4/build/pango'
/usr/bin/g-ir-scanner  --add-include-path=../../pango --add-include-path=. --namespace=PangoXft --nsversion=1.0 --libtool="/bin/bash ../libtool" --pkg=gobject-2.0 --pkg=freetype2 --include=GObject-2.0 --include=xft-2.0 --include=xlib-2.0   --library=libpangoxft-1.0.la --include-uninstalled=./PangoFT2-1.0.gir -I../..   ../../pango/pangoxft.h ../../pango/pangoxft-render.h ../../pango/pangoxft-font.c ../../pango/pangoxft-fontmap.c ../../pango/pangoxft-render.c libpangoxft-1.0.la PangoFT2-1.0.gir --output PangoXft-1.0.gir
/home/michael/debian/build-area/pango-1.28.4/pango/Pango-1.0.gir: Incompatible version 1.1 (supported: 1.2)
make[4]: *** [../../pango/PangoXft-1.0.gir] Error 1
make[4]: Leaving directory `/home/michael/debian/build-area/pango-1.28.4/build/pango'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/michael/debian/build-area/pango-1.28.4/build/pango'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/michael/debian/build-area/pango-1.28.4/build/pango'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/michael/debian/build-area/pango-1.28.4/build'
make: *** [all] Error 2
Comment 2 Martin Pitt 2011-10-19 14:20:46 UTC 
The current 1.29.4 tarball does not ship the pregenerated .gir any more, so apparently this was fixed a while ago.