After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653211 - gnome-control-center fails to set https scheme handler app due to a typo
gnome-control-center fails to set https scheme handler app due to a typo
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-23 04:33 UTC by Alexandre Rostovtsev
Modified: 2011-06-23 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the typo (1.01 KB, patch)
2011-06-23 04:37 UTC, Alexandre Rostovtsev 		committed Details | Review

Description Alexandre Rostovtsev 2011-06-23 04:33:47 UTC 
gnome-control-center (both git master and 3.0.x) fails to set the https scheme handler due to a typo in default_app_changed() in panels/info/cc-info-panel.c

The system info panel includes an app chooser for x-scheme-handler/http. The intent is to use the same app chooser to also set the app for x-scheme-handler/https. However, currently default_app_changed() checks for the https app chooser (which doesn't exist) instead of the http app chooser, and so the https handler app never gets set.
Comment 1 Alexandre Rostovtsev 2011-06-23 04:37:00 UTC 
Created attachment 190497 [details] [review]
Patch to fix the typo

With this patch applied, gnome-control-center correctly sets both the http and https scheme handler application.
Comment 2 Rodrigo Moya 2011-06-23 09:27:19 UTC 
Review of attachment 190497 [details] [review]:

looks good