After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653207 - shellDBus: Add ListExtensions() and GetExtensionInfo()
shellDBus: Add ListExtensions() and GetExtensionInfo()
Status: RESOLVED INVALID
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-23 02:47 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-08-17 13:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
shellDBus: Add ListExtensions() and GetExtensionInfo() (1.63 KB, patch)
2011-06-23 02:47 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
shellDBus: Add ListExtensions() and GetExtensionInfo() (1.71 KB, patch)
2011-06-27 19:11 UTC, Jasper St. Pierre (not reading bugmail)
accepted-commit_now Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-06-23 02:47:33 UTC
These methods are for SweetTooth: the HTTP proxy talks to these methods to get
information about extensions state so it can figure out the right button to
display as well as the correct handler for it.

In the future, this will be used for extension updating.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-06-23 02:47:35 UTC
Created attachment 190489 [details] [review]
shellDBus: Add ListExtensions() and GetExtensionInfo()

GetExtensionInfo() takes a UUID and returns a JSON object with information
about that extension including their metadata, path and current state.

ListExtensions() takes no arguments and returns a JSON object mapping UUIDs
to the same information objects described above.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-06-27 19:11:18 UTC
Created attachment 190787 [details] [review]
shellDBus: Add ListExtensions() and GetExtensionInfo()

GetExtensionInfo() takes a UUID and returns a JSON object with information
about that extension including their metadata, path and current state.

ListExtensions() takes no arguments and returns a JSON object mapping UUIDs
to the same information objects described above.



Fix error with GetExtensionInfo that can happen when the extension is uninstalled
Comment 3 Giovanni Campagna 2011-07-13 17:25:28 UTC
Review of attachment 190787 [details] [review]:

I must admit that trasmitting the whole contents of all metadata.json over the wire everytime ListExtensions is called looks too much, but it is very clean and extensible, so I'd say go for it!
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-07-13 23:54:58 UTC
(In reply to comment #3)
> Review of attachment 190787 [details] [review]:
> 
> I must admit that trasmitting the whole contents of all metadata.json over the
> wire everytime ListExtensions is called looks too much, but it is very clean
> and extensible, so I'd say go for it!

Should I convert these to use {sv} and {s{sv}} instead?
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-07-17 07:43:22 UTC
Sorry for creating a tangled bug mess. I'll have a more linear patch set for all the DBus hacks I need soon.