Bug 653184 - Add device_auto_mount_hint device property
Add device_auto_mount_hint device property
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: libgdu
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-06-22 17:54 UTC by ayan.george
Modified: 2011-07-08 16:23 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch 1/2 - src/gdu/gdu-device.h (1020 bytes, patch)
2011-06-22 17:55 UTC, ayan.george 		rejected Details | Diff | Review
Patch 2/2 - src/gdu/gdu-device.c (1.57 KB, patch)
2011-06-22 17:56 UTC, ayan.george 		rejected Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description ayan.george 2011-06-22 17:54:17 UTC 
freedesktop.org bug for reference:

  https://bugs.freedesktop.org/show_bug.cgi?id=38535

The attached patch adds the device_auto_mount_hint member to the DeviceProperties struct and populates this member in the collect_props() function.

The purpose is to propagate the UDISKS_DEVICE_AUTOMOUNT_HINT udisks property to gvfs.
Comment 1 ayan.george 2011-06-22 17:55:46 UTC 
Created attachment 190459 [details] [review]
Patch 1/2 - src/gdu/gdu-device.h
Comment 2 ayan.george 2011-06-22 17:56:15 UTC 
Created attachment 190460 [details] [review]
Patch 2/2 - src/gdu/gdu-device.c
Comment 3 ayan.george 2011-06-30 11:29:00 UTC 
Review of attachment 190459 [details] [review]:

The latest version of udisks invalidates this patch.  any instance of auto_mount_hint needs to be changed to automount_hint.
Comment 4 ayan.george 2011-06-30 11:29:00 UTC 
Review of attachment 190459 [details] [review]:

The latest version of udisks invalidates this patch.  any instance of auto_mount_hint needs to be changed to automount_hint.
Comment 5 ayan.george 2011-06-30 11:29:42 UTC 
Review of attachment 190460 [details] [review]:

The latest version of udisks invalidates this patch.  any instance of auto_mount_hint needs to be changed to automount_hint.
Comment 6 ayan.george 2011-06-30 11:29:42 UTC 
Review of attachment 190460 [details] [review]:

The latest version of udisks invalidates this patch.  any instance of auto_mount_hint needs to be changed to automount_hint.
Comment 7 David Zeuthen (not reading bugmail) 2011-07-08 15:05:47 UTC 
As I said in the other bug, it needs to be one patch, not two. Also, should return "const char*" to convey the returned string should not be modified. I committed this instead: http://git.gnome.org/browse/gnome-disk-utility/commit/?id=7dde5bc75a1d96be9510ce1e98d28f9d33520919
Comment 8 David Zeuthen (not reading bugmail) 2011-07-08 15:56:48 UTC 
This is in the just-released gnome-disk-utility 3.0.1. For the gvfs bits, you want to depend on this version.
Comment 9 David Zeuthen (not reading bugmail) 2011-07-08 16:23:08 UTC 
You actually want 3.0.2 since the 3.0.1 release was broken in.. interesting ways.
Note You need to log in before you can comment on or make changes to this bug.