After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653167 - Out of tree build is broken on windows
Out of tree build is broken on windows
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: win32
2.29.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-22 13:29 UTC by Dieter Verfaillie
Modified: 2012-03-18 03:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix out of tree windows build (6.65 KB, patch)
2011-06-22 13:29 UTC, Dieter Verfaillie 		none Details | Review
Fix out of tree build, v2 (8.96 KB, patch)
2011-06-22 20:45 UTC, Dieter Verfaillie 		none Details | Review
Fix out of tree build, v3 (8.94 KB, patch)
2011-07-18 12:30 UTC, Dieter Verfaillie 		reviewed Details | Review
Fix out of tree build for MinGW/MSYS (9.52 KB, patch)
2011-08-23 16:48 UTC, Dieter Verfaillie 		none Details | Review
Fix out of tree build for MinGW/MSYS (9.53 KB, patch)
2012-03-18 03:10 UTC, Matthias Clasen 		committed Details | Review

Description Dieter Verfaillie 2011-06-22 13:29:23 UTC 
Created attachment 190438 [details] [review]
Fix out of tree windows build

Out of tree build ($top_srcdir != $top_builddir) is
currently broken on Windows (with MinGW/MSYS).

Attached patch fixes the issue.
Comment 1 Dieter Verfaillie 2011-06-22 20:45:26 UTC 
Created attachment 190473 [details] [review]
Fix out of tree build, v2

Improved patch that:
- doesn't put generated def files in top_builddir but in builddir
- fixes more targets discovered during make install

As far as I can see, this is now complete for the MinGW/MSYS case :)
Comment 2 Dieter Verfaillie 2011-07-18 12:30:38 UTC 
Created attachment 192181 [details] [review]
Fix out of tree build, v3

Rebased patch against master due to changes committed in
7c517bf3501ae68c4a87c8a126955281ad2393b2.
Comment 3 Dieter Verfaillie 2011-08-23 16:48:05 UTC 
Created attachment 194497 [details] [review]
Fix out of tree build for MinGW/MSYS

Rebased against master and rewritten commit message to follow the
guidelines at https://live.gnome.org/GnomeLove/SubmittingPatches
Comment 4 Dieter Verfaillie 2011-08-23 16:49:45 UTC 
Comment on attachment 192181 [details] [review]
Fix out of tree build, v3

Sorry for the noise, forgot to mark this one as obsolete...
Comment 5 Matthias Clasen 2012-03-18 03:09:59 UTC 
The following fix has been pushed:
e2b47ae Fix out of tree build for MinGW/MSYS
Comment 6 Matthias Clasen 2012-03-18 03:10:02 UTC 
Created attachment 210025 [details] [review]
Fix out of tree build for MinGW/MSYS

When building with MinGW/MSYS with srcdir != builddir the build fails:
- to locate the generated .def files
- creating libglib-gdb.py
- creating libgobject-gdb.py

Solved this by explicitly instructing these files to be generated
in $(builddir)/...