After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653142 - Workspaces may end up with a wrong clip due to pager auto-hiding
Workspaces may end up with a wrong clip due to pager auto-hiding
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-21 23:19 UTC by Florian Müllner
Modified: 2011-06-27 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
workspaces-view: Handle clip rectangle separately (3.27 KB, patch)
2011-06-21 23:19 UTC, Florian Müllner
none Details | Review
workspaces-view: Handle clip rectangle separately (3.19 KB, patch)
2011-06-22 01:15 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2011-06-21 23:19:00 UTC
See attached patch - to reproduce, enter the overview with >2 workspaces (so the pager is popped out initially) and move all windows to the first workspace (so the pager auto-hides).
Comment 1 Florian Müllner 2011-06-21 23:19:03 UTC
Created attachment 190402 [details] [review]
workspaces-view: Handle clip rectangle separately

After completing the overview transition, the workspace view is
clipped to avoid overlapping the search entry/view selector titles
while switching workspaces. For clipping, the view's position and
size was used, which works well assuming that the workspace pager
will start hidden or stay zoomed out while the overview is visible.
However, that assumption holds no longer true, as auto-hiding the
pager now depends on the number of workspaces, and thus may change
while in the overview. For instance, when starting with the pager
being visible, the clip area ends up being too small when moving
all windows to the first workspace (and thus triggering auto-hide).

As a fix, handle the clip rectangle separately from the view's
geometry, and set it always to the area the workspaces would
occupy with the pager hidden.
Comment 2 Florian Müllner 2011-06-22 01:15:46 UTC
Created attachment 190405 [details] [review]
workspaces-view: Handle clip rectangle separately

Vertical position/height also have to be treated separately for the clip.
Comment 3 Dan Winship 2011-06-27 12:59:12 UTC
Comment on attachment 190405 [details] [review]
workspaces-view: Handle clip rectangle separately

seems to work
Comment 4 Florian Müllner 2011-06-27 13:23:22 UTC
Attachment 190405 [details] pushed as 6ce07ab - workspaces-view: Handle clip rectangle separately