GNOME Bugzilla – Bug 653060
gnome-shell: wrong date format
Last modified: 2011-08-04 10:41:00 UTC
Also, sesión is wrong and says sesioń.
Created attachment 190323 [details] [review] po: fix Spanish clock time translation Bug #653060
Many thanks for your bug report, Diego. I've applied your patch, and this afternoon will commit the fixed .po.
Diego, Daniel: concerning the misspelled accent, I believe it can be wrong, however I see exactly the same in msgid and msgstr in the diff. And actually, after reading the comments I'm not sure the patch is correct, since there are two strings that specify AM/PM format, and only one is taken into account in the patch, the other is not: #. Translators: This is a time format with date used #. for AM/PM. #: ../js/ui/dateMenu.js:175 msgid "%a %b %e, %l:%M:%S %p" msgstr "%a %e de %b, %H:%M:%S" #: ../js/ui/dateMenu.js:176 msgid "%a %b %e, %l:%M %p" msgstr "%a %e de %b, %H:%M" #. Translators: This is a time format without date used #. for AM/PM. #: ../js/ui/dateMenu.js:180 msgid "%a %l:%M:%S %p" msgstr "%a %H:%M:%S" #: ../js/ui/dateMenu.js:181 msgid "%a %l:%M %p" msgstr "%a %H:%M"
Jorge, you are right. As I've seen in http://www.mkssoftware.com/docs/man3/strftime.3.asp, %l shows the hour in 12-hour format, so %p is needed. We should also change this other strings, but maybe we should use te 24-hour format instead in all strings. What do you think about it?
24h format everywhere would be hardcoding stuff in the translation, evil :). My visible bug right now is that unchecking "Use 24h format" in Date/Time preferences doesn't have any effect. Perú usually plays by am/pm instead of hrs. I thought it was a really long standing bug in my locales or Debian but turns out it was the translation, I hated you guys for a while but then started loving you again :^). So, please don't hardcode it to hrs, and consider fixing all the strings that wrongly changed %l for %H.
Diego, I understand we only have to change those for AM/PM, which is stated in the comment, neither the four of them, nor one you pointed out.
Created attachment 191435 [details] [review] po: fix Spanish clock time translation Bug #653060
Tried gnome-shell master today, I had to make these changes to get the date as I expected it: Jue 7 de Jul, 3:21 AM The AM was missing, which turns out was because the time was in Hrs not AM/PM. On a side note, shouldn't Jue and Jul be on lower? Like jue and jul. Is this something gnome-shell is doing? Or the locale is wrong?
Done in GUADEC Hispana :)