After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653031 - Unbreak introspection generation
Unbreak introspection generation
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Build
3.1.x
Other All
: Normal major
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-20 17:50 UTC by Jasper Lievisse Adriaanse
Modified: 2011-07-13 19:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Using --pkg is enough. (850 bytes, patch)
2011-06-20 17:51 UTC, Jasper Lievisse Adriaanse 		accepted-commit_now Details | Review

Description Jasper Lievisse Adriaanse 2011-06-20 17:50:49 UTC 
g-ir-scanner has the --pkg option exactly for the purpose of yanking
flags out of pkg-config. In addition to using those flags, there is an
explicit callout: pkg-config --libs libxml-2.0 gtk+-3.0 in src/Makefile.am.

This breaks on systems where ther happens to be .pc file with a Libs line that
has the -R directive. Like pangox.pc on OpenBSD:
Libs: -L${libdir} -lpangox-1.0  -L/usr/X11R6/lib -R/usr/X11R6/lib -lX11

g-ir-scanner would error out saying that '-R' is out a valig option.

The attached diff removes the superfluous call to pkg-config.

Would this be allright to commit?
Comment 1 Jasper Lievisse Adriaanse 2011-06-20 17:51:54 UTC 
Created attachment 190302 [details] [review]
Using --pkg is enough.
Comment 2 Jasper Lievisse Adriaanse 2011-07-13 08:58:02 UTC 
Anyone?
Comment 3 Antoine Jacoutot 2011-07-13 09:03:24 UTC 
Would be nice to have someone look at this patch. It looks fine to me and actually fixes a real issue we are seeing.
Comment 4 Colin Walters 2011-07-13 14:47:20 UTC 
Review of attachment 190302 [details] [review]:

Looks right to me, though note that the Gtk-3.0.gir only got the <pkg/> link in the last year is my guess.  But this patch should be fine for epiphany git master.
Comment 5 Jasper Lievisse Adriaanse 2011-07-13 19:42:34 UTC 
Great, thanks!