After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652992 - Remove use of GtkVBox/GtkHBox
Remove use of GtkVBox/GtkHBox
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
git master
Other All
: Normal blocker
: 2.26
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-06-20 10:55 UTC by Philip Withnall
Modified: 2011-07-14 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove use of GtkVBox/GtkHBox (52.69 KB, patch)
2011-06-20 10:58 UTC, Philip Withnall 		none Details | Review
similar patch (49.31 KB, patch)
2011-06-21 05:51 UTC, Kjartan Maraas 		committed Details | Review

Description Philip Withnall 2011-06-20 10:55:20 UTC 
They've been removed in GTK+ in favour of GtkOrientable. Patch coming up to port Brasero to no longer use them.
Comment 1 Philip Withnall 2011-06-20 10:58:55 UTC 
Created attachment 190256 [details] [review]
Remove use of GtkVBox/GtkHBox

Patch to do this. It compiles, but I haven't tested that the interface still works. It should do, though.

(I just wanted Brasero to compile again so that I could build some other stuff.)
Comment 2 Kjartan Maraas 2011-06-21 05:51:45 UTC 
Created attachment 190336 [details] [review]
similar patch

Adding my own version of this just because the number of changes differ to the one here...

54 files changed, 129 insertions(+), 129 deletions(-)
Comment 3 Philip Withnall 2011-06-21 08:57:11 UTC 
Comment on attachment 190256 [details] [review]
Remove use of GtkVBox/GtkHBox

Looks like I got the signature of gtk_box_new() wrong, so your patch is better.
Comment 4 Matthias Clasen 2011-06-29 04:46:59 UTC 
Can we get this committed ?
Comment 5 Matthias Clasen 2011-07-12 00:59:36 UTC 
Can we get this committed, please ?
Comment 6 Cosimo Cecchi 2011-07-14 17:43:21 UTC 
Luis asked me to move this forward on IRC, so I pushed this patch with some additional fixes, which ensure the right orientation is set at _init() time for GtkBox subclasses.