After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652836 - Use the same keyboard layout menu labels as Gnome Shell
Use the same keyboard layout menu labels as Gnome Shell
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-17 14:46 UTC by Jeremy Bicha
Modified: 2011-06-20 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-keyboard-Use-the-same-kbd-layout-menu-labels-as-Gnom.patch (1.32 KB, patch)
2011-06-17 14:47 UTC, Jeremy Bicha 		none Details | Review

Description Jeremy Bicha 2011-06-17 14:46:56 UTC 
1. To reproduce, open System Settings and click Region and Language.
2. Switch to the Layouts tab and click the + to add an extra keyboard layout. Select one and click Add.
3. The keyboard layout menu will show up in the top bar.

If you compare the menu items in Gnome Shell to the ones in the fallback mode, you'll see that the labels are different. In Gnome Shell, it is:

(List of Layouts)
----
Show Keyboard Layout...
Localization Settings

In Fallback, it is:

(List of Layouts)
----
Keyboard _Preferences
Show Current _Layout


Git patch attached.
Comment 1 Jeremy Bicha 2011-06-17 14:47:45 UTC 
Created attachment 190119 [details] [review]
0001-keyboard-Use-the-same-kbd-layout-menu-labels-as-Gnom.patch
Comment 2 Bastien Nocera 2011-06-20 09:27:56 UTC 
It should definitely not read "Localization Settings". Filed against gnome-shell as bug 652984.

commit 7426cffe6292f2ef22538850c24c89b130fb8f49
Author: Jeremy Bicha <jbicha@ubuntu.com>
Date:   Fri Jun 17 10:40:39 2011 -0400

    keyboard: Use the same kbd layout menu labels as Gnome Shell
    
    https://bugzilla.gnome.org/show_bug.cgi?id=652836
Comment 3 Bastien Nocera 2011-06-20 09:30:00 UTC 
Please test your patches in the future, you forgot to swap the signal connections, so clicking on the settings would have shown the current layout. Not very interesting.