GNOME Bugzilla – Bug 652740
Warnings during expansion of content files
Last modified: 2011-09-20 11:26:09 UTC
Expansion of content files causes bogus warnings such as :0: warning: Can't find tag end: ]> in docs for: module-tutorial-tool.xml file. where module-tutorial-tool.xml is the name of the expanded content file. This seems to be a regression. Why it happens? Function ExpandAbbreviationsEndTag() asserts that <!DOCTYPE declaration ends with ]>, not just >. But the square brackets, that enclose internal subset declaration if present, are optional. Content files rarely need to declare internal subsets so they generally do not contain any square brackets in the doctype declaration (heck, the brackets are not even present in files generated by gtk-doc itself). Requiring them makes no sense.
Created attachment 196016 [details] [review] fix regexp can you think of anything that can go wrong with it? tests look good, the few modules I build with it look fine too.
commit f1ab0004900ed3f1fb8b65f8b9889c2241ab1552 Author: Stefan Sauer <ensonic@users.sf.net> Date: Thu Sep 8 19:21:33 2011 +0200 mkdb: doctype does not need to end on ]> Fixes #652740