After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652740 - Warnings during expansion of content files
Warnings during expansion of content files
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.17
Other Linux
: Normal normal
: 1.19
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-16 14:17 UTC by Yeti
Modified: 2011-09-20 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix regexp (1.81 KB, patch)
2011-09-08 17:23 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Yeti 2011-06-16 14:17:17 UTC
Expansion of content files causes bogus warnings such as

   :0: warning: Can't find tag end: ]> in docs for: module-tutorial-tool.xml file.

where module-tutorial-tool.xml is the name of the expanded content file.  This seems to be a regression.

Why it happens?

Function ExpandAbbreviationsEndTag() asserts that <!DOCTYPE declaration ends with ]>, not just >.  But the square brackets, that enclose internal subset declaration if present, are optional.  Content files rarely need to declare internal subsets so they generally do not contain any square brackets in the doctype declaration (heck, the brackets are not even present in files generated by gtk-doc itself). Requiring them makes no sense.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2011-09-08 17:23:05 UTC
Created attachment 196016 [details] [review]
fix regexp

can you think of anything that can go wrong with it? tests look good, the few modules I build with it look fine too.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2011-09-20 11:25:58 UTC
commit f1ab0004900ed3f1fb8b65f8b9889c2241ab1552
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Thu Sep 8 19:21:33 2011 +0200

    mkdb: doctype does not need to end on ]>
    
    Fixes #652740