GNOME Bugzilla – Bug 652730
workspaces-display: Don't slide out pager on drag-begin
Last modified: 2011-06-27 19:39:53 UTC
Proposed by Jasper on IRC, makes sense to me - see attached patch.
Created attachment 190042 [details] [review] workspaces-display: Don't slide out pager on drag-begin Sliding out the workspaces pager when starting a drag causes a lot of motion. With the pager only hiding if workspaces are not used, it is better to require to explicitly hover the workspaces sidebar for the sliding.
Comment on attachment 190042 [details] [review] workspaces-display: Don't slide out pager on drag-begin >+ DND.removeDragMonitor(this._dragMonitor); the method is apparently named "DND.removeMonitor", but a patch to rename it to match "DND.addDragMonitor" would be better than fixing this call.
Created attachment 190779 [details] [review] dnd: Rename DND.removeMonitor() to DND.removeDragMonitor() DND.addDragMonitor() and DND.removeMonitor() are inconsistently named, so rename the latter. (In reply to comment #2) > (From update of attachment 190042 [details] [review]) > >+ DND.removeDragMonitor(this._dragMonitor); > > the method is apparently named "DND.removeMonitor" Ugh. No idea how that happened (referring to the original drag monitor patch, not this one ...)
Attachment 190042 [details] pushed as ed8acef - workspaces-display: Don't slide out pager on drag-begin Attachment 190779 [details] pushed as 737f395 - dnd: Rename DND.removeMonitor() to DND.removeDragMonitor()