GNOME Bugzilla – Bug 652666
ant modtype broken
Last modified: 2011-07-10 03:43:59 UTC
the get_branch call does not get passed the config, thus resulting in a TypeError: get_branch() takes exactly 4 arguments (3 given) this prevents any ant modules from being built using jhbuild
Created attachment 189988 [details] [review] pass the jhbuild config to modtypes.get_branch
You're actually using ant modules? I am about to remove the modtype; see bug 647231. The 'install' currently does nothing, so how can you be using it?
We aren't yet using ant modules, we were thinking to integrate them into our jhbuild moduels when David ran across this bug. If you're removing the modtype, that's fine, feel free to close this. We have a wrapper script we have been using to call ant that works fine.
(In reply to comment #3) > We aren't yet using ant modules, we were thinking to integrate them into our > jhbuild moduels when David ran across this bug. > > If you're removing the modtype, that's fine, feel free to close this. We have > a wrapper script we have been using to call ant that works fine. Ok, what I suggest you do in situations like this (if you aren't already) is create a patch that adds ./configure and Makefile files that Do The Right Thing. The ./configure accepts --prefix and writes it to a file Makefile.config, and the Makefile can just be: include Makefile.config all: ant install: cp foo.jar $(DESTDIR)$(prefix)/share/java See also http://people.gnome.org/~walters/docs/build-api.txt
Thank you for the report & patch. Ant has now been removed from JHBuild. A wrapper script is recommended if you require Ant modules. http://git.gnome.org/browse/jhbuild/commit/?id=8db8d874daa030a0ca6a550f94726f3f6cf96dc0 http://git.gnome.org/browse/jhbuild/commit/?id=aefcb2fb7d53cdd1f0dcc83d122d988afeb94c21