After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652623 - check for HAVE_UTIL_H to prevent implicit declaration
check for HAVE_UTIL_H to prevent implicit declaration
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
git master
Other OpenBSD
: Normal minor
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-15 07:20 UTC by Antoine Jacoutot
Modified: 2012-01-18 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add util.h to the headers check (817 bytes, patch)
2011-06-15 07:20 UTC, Antoine Jacoutot 		committed Details | Review

Description Antoine Jacoutot 2011-06-15 07:20:16 UTC 
Created attachment 189963 [details] [review]
Add util.h to the headers check

Hi.

We need to check for util.h so that HAVE_UTIL_H gets defined and we don't end up with:
pty_open.c:350: warning: implicit declaration of function 'login_tty'
(which I'm seeing on OpenBSD)

Thoughts?
Comment 1 Antoine Jacoutot 2011-12-28 13:33:57 UTC 
Hi.

Anyone to review this, I'd love to be able to push it.
Thanks.
Comment 2 Tomas Bzatek 2012-01-18 16:22:05 UTC 
Good catch, thanks!

commit ac597c44a52a5fc4c3e20ee75e7d82f691722feb
Author: Antoine Jacoutot <ajacoutot@openbsd.org>
Date:   Wed Jan 18 17:19:34 2012 +0100

    build: Check for util.h to prevent implicit declaration
    
    https://bugzilla.gnome.org/show_bug.cgi?id=652623
    
    Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>