After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652597 - Drop _blockMethod and some JSAPI usage
Drop _blockMethod and some JSAPI usage
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-14 20:47 UTC by Colin Walters
Modified: 2011-06-20 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
environment: Remove usage of _blockMethod; we've fixed both Clutter and GDK (2.30 KB, patch)
2011-06-14 20:47 UTC, Colin Walters 		reviewed Details | Review
shell_global_set_property_mutable: Remove (4.23 KB, patch)
2011-06-14 20:47 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2011-06-14 20:47:05 UTC 
See patches
Comment 1 Colin Walters 2011-06-14 20:47:07 UTC 
Created attachment 189940 [details] [review]
environment: Remove usage of _blockMethod; we've fixed both Clutter and GDK

See bug 597292.
Comment 2 Colin Walters 2011-06-14 20:47:09 UTC 
Created attachment 189941 [details] [review]
shell_global_set_property_mutable: Remove

All introspection properties are now writable;
See https://bugzilla.gnome.org/show_bug.cgi?id=646633
Comment 3 Dan Winship 2011-06-14 21:03:54 UTC 
Comment on attachment 189940 [details] [review]
environment: Remove usage of _blockMethod; we've fixed both Clutter and GDK

Not sure it makes sense to remove _blockMethod entirely... there may be other issues in the future. (Or the present. I recently reviewed a patch that used Clutter.get_current_event_time() instead of global.get_current_time().)

I suppose it could be simplified vastly now that we don't need set_property_mutable() though, so maybe it does make sense to kill it for now.
Comment 4 Dan Winship 2011-06-14 21:04:20 UTC 
Comment on attachment 189941 [details] [review]
shell_global_set_property_mutable: Remove

ok
Comment 5 Colin Walters 2011-06-20 21:58:42 UTC 
Attachment 189941 [details] pushed as 26aa433 - shell_global_set_property_mutable: Remove