After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652546 - Add X-GOOGLE-PLATFORM support
Add X-GOOGLE-PLATFORM support
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Auth client
3.3.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
: 647007 677864 683766 (view as bug list)
Depends on: 661065
Blocks:
 
 
Reported: 2011-06-14 11:40 UTC by Guillaume Desmottes
Modified: 2014-10-22 09:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implement Google OAUTH2 authentication for GOA accounts (1.47 KB, patch)
2012-10-28 12:26 UTC, Giovanni Campagna
committed Details | Review

Description Guillaume Desmottes 2011-06-14 11:40:34 UTC
As with Facebook (bug #652544) we should implement Google Talk SSO mechanism.
Comment 1 Guillaume Desmottes 2011-06-14 11:42:20 UTC
See also https://bugs.freedesktop.org/show_bug.cgi?id=37376
Comment 2 Xavier Claessens 2011-10-06 09:50:19 UTC
Does X-GOOGLE-PLATFORM exists? I see only X-OAUTH2 in the XMPP auth mechanisms.

GOA does not give a OAUTH2 access-token though, see bug #661065.
Comment 3 Guillaume Desmottes 2011-10-08 20:16:19 UTC
Not really, afaik GTalk only supports oauth2; the idea X-GOOGLE-PLATFORM of is implementing the underlying oauth2 in Gabble/Wocky rather than in each client; see https://bugs.freedesktop.org/show_bug.cgi?id=37376
Comment 4 Cosimo Cecchi 2012-03-20 23:53:21 UTC
This is still relevant for 3.3.92, I just got the password dialog on a newly created Google account. I propose to raise the importance of this issue, as having it would add quite some polish to the overall chat experience.
Comment 5 Guillaume Desmottes 2012-03-21 08:48:27 UTC
I totally agree with you but except if GTalk starts supporting oauth1, the only way to fix this bug is to get an oauth2 token from GOA which has been rejected: bug #661065
Comment 6 Guillaume Desmottes 2012-07-10 10:44:47 UTC
*** Bug 677864 has been marked as a duplicate of this bug. ***
Comment 7 Guillaume Desmottes 2012-09-11 08:50:38 UTC
We actually implement this now with UOA. It would be trivial to support GOA as well but as long as it doesn't give us the oauth2 token there is no much we can do. Closing this bug as bug #661065 as been marked as WONTFIX by GOA developers.
Comment 8 Debarshi Ray 2012-09-11 08:56:08 UTC
(In reply to comment #7)
> We actually implement this now with UOA. It would be trivial to support GOA as
> well but as long as it doesn't give us the oauth2 token there is no much we can
> do. Closing this bug as bug #661065 as been marked as WONTFIX by GOA
> developers.

WONTFIX is a bit of an oversimplification. :-)

We couldn't do OAuth2 for Google because we rely on OAuth1 for GMail IMAP as stated here: https://bugzilla.gnome.org/show_bug.cgi?id=661065#c1

Now, reading Google's documentation it seems that it might be possible to do GMail IMAP over OAuth2, but the documentation does not say it clearly either. Atleast I could not find it. So the only way to find out is to write the code and try if it works.
Comment 9 Guillaume Desmottes 2012-09-11 09:20:33 UTC
*** Bug 683766 has been marked as a duplicate of this bug. ***
Comment 10 Giovanni Campagna 2012-10-28 12:26:33 UTC
Created attachment 227455 [details] [review]
Implement Google OAUTH2 authentication for GOA accounts

GOA recently switched to OAuth2 for Google accounts, so we
can use its credentials to access Google Talk without a password.
Comment 11 Guillaume Desmottes 2012-11-02 11:26:33 UTC
Review of attachment 227455 [details] [review]:

Looks good, thanks!

::: libempathy/empathy-goa-auth-handler.c
@@ +187,3 @@
+            goa_account_get_identity (goa_object_peek_account (data->goa_object)),
+            access_token,
+            auth_cb, data);

This one can stay on the same line as 'acces_token'.
Comment 12 Giovanni Campagna 2012-11-02 13:07:56 UTC
Attachment 227455 [details] pushed as 0bd9b3a - Implement Google OAUTH2 authentication for GOA accounts
Comment 13 Allan Day 2012-11-02 13:22:54 UTC
YAAYYYYYY!
Comment 14 Debarshi Ray 2012-11-05 22:28:12 UTC
*** Bug 647007 has been marked as a duplicate of this bug. ***
Comment 15 ubuntumuntu 2014-10-22 09:02:10 UTC
GAuth 2FA is supported, but does not address the per-app access token.

Might be related to a larger auth issue.
I've filed a bug: Bug 738995