After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652522 - Searching for string in logs no longer highlights find
Searching for string in logs no longer highlights find
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Archives
unspecified
Other Linux
: Normal normal
: 3.2
Assigned To: empathy-maint
: 593733 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-06-14 06:47 UTC by Jonny Lamb
Modified: 2011-06-21 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jonny Lamb 2011-06-14 06:47:43 UTC 
If you search for "foo", it'll show you the search results with "foo" in the chats, but won't highlight "foo" at all. Please do!
Comment 1 Emilio Pozuelo Monfort 2011-06-20 15:37:08 UTC 
*** Bug 593733 has been marked as a duplicate of this bug. ***
Comment 2 Guillaume Desmottes 2011-06-21 11:02:07 UTC 
Review of http://cgit.collabora.com/git/user/pochu/empathy.git/commit/?h=history-ui&id=c8b72e7d79946bc788699f01581f782933829cd7

+      gchar *str = g_regex_escape_string (log_window->last_find, -1);
+      gchar *replacement = g_markup_printf_escaped (
+      GRegex *regex = g_regex_new (str, 0, 0, &error);
+          gchar *new_msg = g_regex_replace_literal (regex,

All of those are leaked.

I usually prefer if (badger == NULL) rather than if (error != NULL).
Comment 3 Emilio Pozuelo Monfort 2011-06-21 11:55:55 UTC 
commit 5faa536ed6fc6ce21421900d4ddea64c61f5182a
Author: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Date:   Mon Jun 20 17:38:32 2011 +0100

    LogWindow: highlight the searched text
    
    https://bugzilla.gnome.org/show_bug.cgi?id=652522