After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652507 - Create the 1x1 texture for the root background unsliced
Create the 1x1 texture for the root background unsliced
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Florian Müllner
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-13 21:27 UTC by Owen Taylor
Modified: 2011-06-29 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Create the 1x1 texture for the root background unsliced (4.31 KB, patch)
2011-06-13 21:27 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2011-06-13 21:27:15 UTC 
When there was no root background pixmap, we were using a 1x1 repeating
texture as a simple way of drawing a solid color without adding a
second code path. However, when that 1x1 texture was combined into
a larger "atlas texture", hardware repeat couldn't be used, so a
small inefficiency from this approach became an enormous inefficiency
as clutter drew every pixel of the background as a separate rectangle.
Comment 1 Owen Taylor 2011-06-13 21:27:18 UTC 
Created attachment 189853 [details] [review]
Create the 1x1 texture for the root background unsliced
Comment 2 Florian Müllner 2011-06-16 13:22:22 UTC 
Review of attachment 189853 [details] [review]:

Mmmh, is it particularly important to allow slicing for the dummy texture in meta_create_texture_material()? Other than that looks good to commit after adding the new 'flags' parameter in the gtk-doc comment.
Comment 3 Owen Taylor 2011-06-29 16:25:34 UTC 
1x1 textures are the place where we most would want slicing - there's quite a bit of constant overhead for each texture - get rounded up to a page, have to change memory map tables on the processor, syscall to create and destroy, etc. It wouldn't *really* hurt to create a few extra textures, but best to avoid it.
Comment 4 Owen Taylor 2011-06-29 16:27:45 UTC 
Attachment 189853 [details] pushed as fe12294 - Create the 1x1 texture for the root background unsliced