After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652504 - g-d-u is using hbox/vbox
g-d-u is using hbox/vbox
Status: RESOLVED WONTFIX
Product: gnome-disk-utility
Classification: Core
Component: general
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-13 21:21 UTC by Sergey V. Udaltsov
Modified: 2011-07-11 01:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch for g-d-u (34.59 KB, patch)
2011-06-13 21:31 UTC, Sergey V. Udaltsov 		committed Details | Review
Replacing hbox/vbox with box (34.59 KB, patch)
2011-06-16 11:25 UTC, Matthias Clasen 		committed Details | Review

Description Sergey V. Udaltsov 2011-06-13 21:21:40 UTC 
GTK deprecated hbox/vbox
Comment 1 Sergey V. Udaltsov 2011-06-13 21:31:57 UTC 
Created attachment 189854 [details] [review]
The patch for g-d-u

Here is the minimal patch for that issue
Comment 2 Matthias Clasen 2011-06-16 11:25:44 UTC 
The following fix has been pushed:
05a5635 Replacing hbox/vbox with box
Comment 3 Matthias Clasen 2011-06-16 11:25:51 UTC 
Created attachment 190030 [details] [review]
Replacing hbox/vbox with box

GTK deprecated hbox/vbox. Simple change makes g-d-u compilable at least
Comment 4 David Zeuthen (not reading bugmail) 2011-07-08 16:45:22 UTC 
Reverted this since the patch was wrong, see

 http://people.freedesktop.org/~david/never-commit-before-testing-the-patch.png

I've instead cleaned up the build system so it doesn't automatically add DISABLED_DEPRECATED.

Closing as WONTFIX as the udisks2-port is a complete rewrite and where we should focus our efforts.
Comment 5 Sergey V. Udaltsov 2011-07-11 01:21:12 UTC 
As I said, it was minimal patch, basically "search/replace" thing. Perhaps killing DISABLE_DEPRECATED was the better thing to do. Sorry for the hassle.