GNOME Bugzilla – Bug 652439
Can't open conversation tabs from the contact list if the conversation is open in the shell
Last modified: 2011-07-11 12:41:43 UTC
Preconditions: • have the very latest versions of MC, Empathy, and Gnome Shell Steps to reproduce: • Have a conversation window open in the Shell; • Find that contact in your Empathy contact list; • Double-click them. Expected results: • An Empathy conversation tab pops up. Actual results: • The Shell bubble pops up. Discussion: This is because the Shell is the handler of the channel. The contact list uses EnsureChannel; so MC just calls HandleChannels() on the current handler. A potential fix would be to include a hint with the channel request to say “delegate this please”; the Shell would look for that hint and, if present, delegate the channel to the PreferredHandler.
This needs some spec work: https://bugs.freedesktop.org/show_bug.cgi?id=38240
Fixed in https://bugzilla.gnome.org/show_bug.cgi?id=652439 but depends on the tp-glib branch to be merged and released.
Created attachment 191513 [details] [review] coding style fixes
Created attachment 191514 [details] [review] Set the DelegateToPreferredHandler hint when requesting text channels (#652439) This ensures that Empathy will always handle and display the channel, even if GNOME Shel is already handling it.
Comment on attachment 191513 [details] [review] coding style fixes Looks good
Comment on attachment 191514 [details] [review] Set the DelegateToPreferredHandler hint when requesting text channels (#652439) Looks good, the only issue is that the commit message is too long (the summary line), so it'd be good if you can make it a bit shorter. ++
Attachment 191513 [details] pushed as a446f3e - coding style fixes