GNOME Bugzilla – Bug 652425
Failure codes for removing personas needed in PersonaStoreError
Last modified: 2011-07-20 19:27:06 UTC
There is no suitable set of error codes in Folks.PersonaStoreError to express the errors you might encounter while trying to remove a persona from a PersonaStore. Possible error codes: PERMISSON_DENIED REMOVAL_FAILED etc.
(mass changing milestones)
Created attachment 191646 [details] [review] Add failure codes for removing personas to PersonaStoreError https://www.gitorious.org/folks/folks/commits/652425-persona-store-error-codes Having looked at the errors in EBookStatus[1], I can't come up with any other error codes apart from the ones suggested by Raúl. Here's a patch to add them. [1]: http://git.gnome.org/browse/evolution-data-server/tree/addressbook/libebook/e-book-types.h#n23
Review of attachment 191646 [details] [review]: Please s/since 0.5.UNRELEASED/since UNRELEASED/ It's more future-proof in general and we usually use the latter form (so we can just run a small multi-file replace during release processing). After that, apply.
Comment on attachment 191646 [details] [review] Add failure codes for removing personas to PersonaStoreError Committed with the changes. commit 61a22e725900c0a002357abb06b33746836c11ad Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sun Jul 10 18:44:31 2011 +0100 Fix the error domain of PersonaStore.remove_persona() NEWS | 2 ++ folks/persona-store.vala | 3 ++- 2 files changed, 4 insertions(+), 1 deletions(-) commit 7ca922ad06ca2ff9b46e4d8f745a7dd42e2668cd Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sun Jul 10 18:41:25 2011 +0100 Bug 652425 — Failure codes for removing personas needed in PersonaStoreError Add PersonaStoreError.PERMISSION_DENIED and PersonaStoreError.REMOVE_FAILED, which will be useful for the e-d-s backend. Closes: bgo#652425 NEWS | 2 ++ folks/persona-store.vala | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-)