Created attachment 189757 [details] [review]
GDesktopAppInfo: Add g_desktop_app_info_get_nodisplay

Necessary for rebasing gnome-menus on top of GDesktopAppInfo.

https://bugzilla.gnome.org/show_bug.cgi?id=647967

Review of attachment 189757 [details] [review]:

I

::: gio/gdesktopappinfo.c
@@ +684,3 @@
+ *
+ * Since: 2.30
+ */

It seems a little dubious that the docs for this function say exactly the same as the docs for g_app_info_should_show(), even though the functions don't do the same thing...

Hrm, true. What about: "Gets the value of the NoDisplay key, which helps determine if the application info should be shown in menus. See  #G_KEY_FILE_DESKTOP_KEY_NO_DISPLAY and g_app_info_should_show()."

Yes, thats better. Feel free to commit it with that change.
Still wondering if just adding an escape hatch like

gchar * g_desktop_app_info_get_key (GDesktopAppInfo *info, const gchar *key)

would be easier, rather than adding more and more getters one-by-one

Thanks, pushed.

(In reply to comment #4)
> Still wondering if just adding an escape hatch like
> 
> gchar * g_desktop_app_info_get_key (GDesktopAppInfo *info, const gchar *key)
> 
> would be easier, rather than adding more and more getters one-by-one

That'd imply keeping the keyfile around (or at least the hash table of keys), which we don't do right now. But that might make sense, yes.