After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652321 - Move progress bar away from icon in OSD
Move progress bar away from icon in OSD
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-10 20:03 UTC by Daniel Rodrigues
Modified: 2013-01-12 21:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Side-by-side comparison (mockup vs implementation) (116.82 KB, image/png)
2011-06-10 20:03 UTC, Daniel Rodrigues
  Details
media-keys: Remove progress bar borders (1.51 KB, patch)
2011-07-01 13:30 UTC, Bastien Nocera
committed Details | Review
media-keys: Remove OSD border (1.62 KB, patch)
2011-07-01 13:30 UTC, Bastien Nocera
committed Details | Review
media-keys: Make icon smaller in OSD (903 bytes, patch)
2011-07-01 13:35 UTC, Bastien Nocera
committed Details | Review
osd-window: consolidate code to calculate icon/volume bounding boxes (14.85 KB, patch)
2013-01-11 17:43 UTC, Cosimo Cecchi
committed Details | Review
osd-window: use GTK_STATE_FLAG_NORMAL, not GTK_STATE_NORMAL (2.18 KB, patch)
2013-01-11 17:43 UTC, Cosimo Cecchi
committed Details | Review
osd-window: make the window smaller (1.75 KB, patch)
2013-01-11 17:43 UTC, Cosimo Cecchi
committed Details | Review
osd-window: tweak the volume bar position/size (3.71 KB, patch)
2013-01-11 17:43 UTC, Cosimo Cecchi
committed Details | Review
how it looks (20.90 KB, image/png)
2013-01-11 17:45 UTC, Cosimo Cecchi
  Details

Description Daniel Rodrigues 2011-06-10 20:03:46 UTC
Created attachment 189671 [details]
Side-by-side comparison (mockup vs implementation)

The on-screen controls for volume/brightness changes don't follow the style proposed in their respective mockup [1]. 

Attached is a comparison between the mockup style and the current style (as of GNOME 3.0.2 on Fedora 15).

It's easily notable that the current implementation lacks color vivacity, clearly defined strokes and a rounded progress slider. 

The current icons also seem to be blurry (this side-by-side view with the mockup emphasizes it really well). 

All this may happen due to the artwork assets or there's likewise the possibility of a rendering bug. 

[1] http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/symbolic/osd-symbolic.png
Comment 1 Bastien Nocera 2011-07-01 13:30:26 UTC
<jimmac> hadess, had I the ability, here's what I would do to the current volume osd - get rid of the stroke for the container rectangle and the 'progress'. scale down the icon slightly to give it more "air"
Comment 2 Bastien Nocera 2011-07-01 13:30:44 UTC
Created attachment 191094 [details] [review]
media-keys: Remove progress bar borders
Comment 3 Bastien Nocera 2011-07-01 13:30:52 UTC
Created attachment 191095 [details] [review]
media-keys: Remove OSD border
Comment 4 Bastien Nocera 2011-07-01 13:35:29 UTC
Created attachment 191096 [details] [review]
media-keys: Make icon smaller in OSD
Comment 5 Bastien Nocera 2011-07-01 14:25:41 UTC
commit 0fd1068468e2cbde9d3761ef2ce8afdef392334b
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Jul 1 14:34:43 2011 +0100

    media-keys: Make icon smaller in OSD
    
    https://bugzilla.gnome.org/show_bug.cgi?id=652321

commit f8f0ff537ab72aec7dd4a0e54e16ee35b81b64b8
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Jul 1 14:29:06 2011 +0100

    media-keys: Remove OSD border
    
    https://bugzilla.gnome.org/show_bug.cgi?id=652321

commit 303170d16c3c2fee8033f9701b4799d1c37d7da6
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Jul 1 14:20:29 2011 +0100

    media-keys: Remove progress bar borders
    
    https://bugzilla.gnome.org/show_bug.cgi?id=652321

commit bacb20270cde60cc71bff6723336e50acc3935b2
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Jul 1 14:33:56 2011 +0100

    media-keys: Use constant for icon size in OSD
Comment 6 Bastien Nocera 2011-07-01 14:32:20 UTC
Still need to tweak the progress bar to be a bit further away from the icon itself, loads of dead space.
Comment 7 Cosimo Cecchi 2013-01-11 17:43:07 UTC
Created attachment 233248 [details] [review]
osd-window: consolidate code to calculate icon/volume bounding boxes

Instead of copying it between two functions, factor it out.
Comment 8 Cosimo Cecchi 2013-01-11 17:43:10 UTC
Created attachment 233249 [details] [review]
osd-window: use GTK_STATE_FLAG_NORMAL, not GTK_STATE_NORMAL

The GtkStyleContext API takes a GtkStateFlags.
Comment 9 Cosimo Cecchi 2013-01-11 17:43:13 UTC
Created attachment 233250 [details] [review]
osd-window: make the window smaller

Matches the mockups better; to compensate, make the icon take up more
space inside.
Comment 10 Cosimo Cecchi 2013-01-11 17:43:16 UTC
Created attachment 233251 [details] [review]
osd-window: tweak the volume bar position/size

Make it a little wider than the icon itself, to match the mockups
better. Also, move it down and ensure it has a minimum radius.
Comment 11 Cosimo Cecchi 2013-01-11 17:45:25 UTC
Created attachment 233253 [details]
how it looks
Comment 12 Bastien Nocera 2013-01-11 18:03:51 UTC
Review of attachment 233248 [details] [review]:

++
Comment 13 Bastien Nocera 2013-01-11 18:04:14 UTC
Review of attachment 233249 [details] [review]:

++
Comment 14 Bastien Nocera 2013-01-11 18:05:01 UTC
Review of attachment 233250 [details] [review]:

++
Comment 15 Bastien Nocera 2013-01-11 18:05:55 UTC
Review of attachment 233251 [details] [review]:

++
Comment 16 Bastien Nocera 2013-01-11 18:09:07 UTC
Please use "media-keys" as the prefix for the patches.

Bug 670747 and bug 675901 need to print text in addition to the the "volume bar". Do we have mockups for those?
Comment 17 Bastien Nocera 2013-01-12 21:12:51 UTC
Fixed in master, thanks!