GNOME Bugzilla – Bug 652321
Move progress bar away from icon in OSD
Last modified: 2013-01-12 21:13:05 UTC
Created attachment 189671 [details] Side-by-side comparison (mockup vs implementation) The on-screen controls for volume/brightness changes don't follow the style proposed in their respective mockup [1]. Attached is a comparison between the mockup style and the current style (as of GNOME 3.0.2 on Fedora 15). It's easily notable that the current implementation lacks color vivacity, clearly defined strokes and a rounded progress slider. The current icons also seem to be blurry (this side-by-side view with the mockup emphasizes it really well). All this may happen due to the artwork assets or there's likewise the possibility of a rendering bug. [1] http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/symbolic/osd-symbolic.png
<jimmac> hadess, had I the ability, here's what I would do to the current volume osd - get rid of the stroke for the container rectangle and the 'progress'. scale down the icon slightly to give it more "air"
Created attachment 191094 [details] [review] media-keys: Remove progress bar borders
Created attachment 191095 [details] [review] media-keys: Remove OSD border
Created attachment 191096 [details] [review] media-keys: Make icon smaller in OSD
commit 0fd1068468e2cbde9d3761ef2ce8afdef392334b Author: Bastien Nocera <hadess@hadess.net> Date: Fri Jul 1 14:34:43 2011 +0100 media-keys: Make icon smaller in OSD https://bugzilla.gnome.org/show_bug.cgi?id=652321 commit f8f0ff537ab72aec7dd4a0e54e16ee35b81b64b8 Author: Bastien Nocera <hadess@hadess.net> Date: Fri Jul 1 14:29:06 2011 +0100 media-keys: Remove OSD border https://bugzilla.gnome.org/show_bug.cgi?id=652321 commit 303170d16c3c2fee8033f9701b4799d1c37d7da6 Author: Bastien Nocera <hadess@hadess.net> Date: Fri Jul 1 14:20:29 2011 +0100 media-keys: Remove progress bar borders https://bugzilla.gnome.org/show_bug.cgi?id=652321 commit bacb20270cde60cc71bff6723336e50acc3935b2 Author: Bastien Nocera <hadess@hadess.net> Date: Fri Jul 1 14:33:56 2011 +0100 media-keys: Use constant for icon size in OSD
Still need to tweak the progress bar to be a bit further away from the icon itself, loads of dead space.
Created attachment 233248 [details] [review] osd-window: consolidate code to calculate icon/volume bounding boxes Instead of copying it between two functions, factor it out.
Created attachment 233249 [details] [review] osd-window: use GTK_STATE_FLAG_NORMAL, not GTK_STATE_NORMAL The GtkStyleContext API takes a GtkStateFlags.
Created attachment 233250 [details] [review] osd-window: make the window smaller Matches the mockups better; to compensate, make the icon take up more space inside.
Created attachment 233251 [details] [review] osd-window: tweak the volume bar position/size Make it a little wider than the icon itself, to match the mockups better. Also, move it down and ensure it has a minimum radius.
Created attachment 233253 [details] how it looks
Review of attachment 233248 [details] [review]: ++
Review of attachment 233249 [details] [review]: ++
Review of attachment 233250 [details] [review]: ++
Review of attachment 233251 [details] [review]: ++
Please use "media-keys" as the prefix for the patches. Bug 670747 and bug 675901 need to print text in addition to the the "volume bar". Do we have mockups for those?
Fixed in master, thanks!