GNOME Bugzilla – Bug 652285
glib port to interix
Last modified: 2018-05-24 13:10:31 UTC
Created attachment 189624 [details] [review] patch to make glib compile/run on interix. I did some porting to Interix, recently, and i think that other platforms might benefit from the effort too. In the attached patch, appart from making it compile and mostly run on interix, i made IPV6 optional (older interixen don't even define AF_INET6, so....). Could i ask for a round of reviews for the patch? thanks!
Please break this patch up into parts, preferably like this: * An initial patch to configure.ac to add whatever new checks are necessary * Patches to glib/ * Patches to gio/ Each patch should be in "git format-patch" style with a commit message and rationale. For more information, see: http://live.gnome.org/GnomeLove/SubmittingPatches
ok, will do this ASAP :)
One drive by: +++ glib-2.28.6/gio/gioenumtypes.c 2011-06-09 13:57:48 +0200 @@ -646,7 +646,9 @@ { G_SOCKET_FAMILY_INVALID, "G_SOCKET_FAMILY_INVALID", "invalid" }, { G_SOCKET_FAMILY_UNIX, "G_SOCKET_FAMILY_UNIX", "unix" }, { G_SOCKET_FAMILY_IPV4, "G_SOCKET_FAMILY_IPV4", "ipv4" }, +#ifdef G_SOCKET_FAMILY_IPV6 { G_SOCKET_FAMILY_IPV6, "G_SOCKET_FAMILY_IPV6", "ipv6" }, +#endif { 0, NULL, NULL } }; GType g_define_type_id = I think it's a bad idea to change public API like this. Rather, functions should accept G_SOCKET_FAMILY_IPV6, but return an error (G_IO_ERROR, G_IO_ERROR_NOT_SUPPORTED).
Alternatively, and probably even better is to structure the patches along vertical changes. For example, a patch to configure.ac that checks for nanosleep and also uses the new #ifdef in glib/gtimer.c.
Review of attachment 189624 [details] [review]: reflecting earlier comments
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/416.