GNOME Bugzilla – Bug 652239
win32: resurect Windows clipboard selection notification
Last modified: 2011-10-25 05:31:07 UTC
This is a rewrite of e6fa7394baa8a7cb80ae01a0c81729717019172b, with misc fixes that should help with some bugs Tim was talking about.
Created attachment 189589 [details] [review] win32: resurect Windows clipboard selection notification
Review of attachment 189589 [details] [review]: yes, I also removed a few trailing ws, I guess that's okayish..
(In reply to comment #2) > Review of attachment 189589 [details] [review]: > > yes, I also removed a few trailing ws, I guess that's okayish.. Sure, thats fine.
If the patch makes things work better on win32, I would say go ahead and commit it.
I would like to kow waht it is supposed to do better, i.e what problem does it solve. At least I do not understand it from the patch nor from Tor's removal comment: "* gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code. It didn't really do anything useful, and was just confusing and incomplete." http://git.gnome.org/browse/gtk+/commit/?id=e6fa7394baa8a7cb80ae01a0c81729717019172b
(In reply to comment #5) > I would like to kow waht it is supposed to do better, i.e what problem does it > solve. At least I do not understand it from the patch nor from Tor's removal > comment: "* gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code. It > didn't really do anything useful, and was just confusing and incomplete." > > http://git.gnome.org/browse/gtk+/commit/?id=e6fa7394baa8a7cb80ae01a0c81729717019172b Hans, it simply implements a clipboard notified (it's called clipboard viewer in Wndows). The old version wasn't actually sending GDK_OWNER_CHANGE events, so it didn't work in fact. Also, the *big* mistake was that it didn't forward WM_CHANGECBCHAIN to the next viewer. And it was also lacking some error checking. (note: the new way of doing things is AddClipboardFormatListener, but it's only on >= Vista, and its not yet supported by mingw)
Attachment 189589 [details] pushed as 88707e6 - win32: resurect Windows clipboard selection notification
Hi, I tried GTK+-2.24.7 with mypaint as reported here http://gna.org/bugs/?18278 but still have the issue. Use case: Start mypaint with empty canvas Start MS Paint, make doodle and copy part of it into clipboard Paste on mypaint, which seems OK at first Modify my doodling in MS Paint and copy again to clipboard (different data and size) Paste again on mypaint, but this time it keep paste the previous image and so forth
Just re-read the note, so this isn't for XP nor MinGW?
(In reply to comment #9) > Just re-read the note, so this isn't for XP nor MinGW? Bakhtiar, the patch was not about copy-paste function itself, but rather the notification of clipboard changes. I don't think it's related to the bug you described, which seems to be broken copy-paste, with outdated data.
OK thanks for your confirmation! will search for similar report then.