Created attachment 189558 [details] [review]
test: do not use G_CONST_RETURN

Created attachment 189559 [details] [review]
atk: Do not use G_CONST_RETURN

I have tried it and seems to work.

Anyway, on bug 652005 comment 8 and comment 9 Matthias says that it is not clear what to do on the public APIs. Your two patches also modified the public APIs. So I would like to wait for that conclusion.

Subsequent irc discussion has convinced me that we should really do this.

Review of attachment 189559 [details] [review]:

::: atk/atkdocument.h
@@ +70,3 @@
 
+const gchar*          atk_document_get_document_type (AtkDocument   *document);
+gpointer              atk_document_get_document (AtkDocument   *document);

Just a nitpick: you modify also this line, although it is not related at all with the G_CONST_RETURN -> const move, is just cleaning the indentation, so not related with this bug.

Could you change this? There are other places on the patch with this "indentation changes".

Well, my first plan was waiting for Li bless. Anyway, taking into account that G_CONST_RETURN will be deprecated, and that it is already being applied on other modules (ie: gtk), I think that this wouldn't be a problem.

So, modify the second patch in order to be "just a G_CONST_RETURN -> const" change, and apply it.

Thanks.

Comment on attachment 189558 [details] [review]
test: do not use G_CONST_RETURN

commit 28ca51e39e84ee280e4352e752593d77810b1ba8

Comment on attachment 189559 [details] [review]
atk: Do not use G_CONST_RETURN

Sorry for the delay. Committeed with the required changes ;)

commit 2b6504ef3a8eb22b4d00c933e041fe2e1423142a