After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652201 - Use GtkOrientable interface instead of deprecated V/H widgets
Use GtkOrientable interface instead of deprecated V/H widgets
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-09 15:11 UTC by Claudio Saavedra
Modified: 2011-06-09 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use gtk_box_pack_start() with EphyEmbed (1.03 KB, patch)
2011-06-09 15:11 UTC, Claudio Saavedra 		committed Details | Review
Use GtkOrientable interface instead of deprecated V/H widgets (19.07 KB, patch)
2011-06-09 15:11 UTC, Claudio Saavedra 		committed Details | Review

Description Claudio Saavedra 2011-06-09 15:11:18 UTC 
These widgets were recently deprecated, breaking the build with GTK_DISABLE_DEPRECATED.

Also, the default GtkBox:expand value has changed, so it's not a good idea to rely on it. The first patch fixes this.
Comment 1 Claudio Saavedra 2011-06-09 15:11:20 UTC 
Created attachment 189553 [details] [review]
use gtk_box_pack_start() with EphyEmbed

Using gtk_container_add() is a bad idea because default fill/expand
values can change, and they happened to do in GTK+ 3.1.
Comment 2 Claudio Saavedra 2011-06-09 15:11:24 UTC 
Created attachment 189554 [details] [review]
Use GtkOrientable interface instead of deprecated V/H widgets

Gtk[HV]Box, Gtk[HV]Separator, Gtk[HV]Paned are deprecated in GTK+ 3.2,
so let's use the GtkOrientable interface instead.

GtkBox is likely to dissapear soon too, so a migration to GtkGrid
might be necessary at some point.
Comment 3 Xan Lopez 2011-06-09 16:24:49 UTC 
Review of attachment 189553 [details] [review]:

Looks good.
Comment 4 Xan Lopez 2011-06-09 16:26:34 UTC 
Review of attachment 189554 [details] [review]:

Looks good.
Comment 5 Claudio Saavedra 2011-06-09 16:33:01 UTC 
Thanks for reviewing.

Attachment 189553 [details] pushed as 0f61b9b - use gtk_box_pack_start() with EphyEmbed
Attachment 189554 [details] pushed as ffae9a0 - Use GtkOrientable interface instead of deprecated V/H widgets