After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652192 - gtk3 support
gtk3 support
Status: RESOLVED FIXED
Product: gnome-phone-manager
Classification: Other
Component: general
0.66
Other Linux
: Normal normal
: ---
Assigned To: none
none
Depends on:
Blocks:
 
 
Reported: 2011-06-09 14:01 UTC by Jan de Groot
Modified: 2017-12-02 21:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Port to gtk3 (1.97 KB, patch)
2011-06-30 17:58 UTC, Jan de Groot
committed Details | Review
ui: require gtk3 (92.75 KB, patch)
2017-12-02 21:55 UTC, Ladislav Michl
none Details | Review

Description Jan de Groot 2011-06-09 14:01:13 UTC
With the release of gnome-bluetooth 3.0, gnome-phone-manager no longer works, as it links both gtk2 and gtk3 symbols into one application. For this, gnome-phone-manager should get ported to GTK3.

I've done some initial work on it, patching it is trivial:
- remove gtkspell from configure.ac
- change gtk+-2.0 to gtk+-3.0 in configure.ac
- Remove the gtkspell include and the block that iniaitlizes gtkspell from src/ui.c

Doing this is fairly simple and generates a short patch. Is this what we want, or do we want to support older versions? In that case, I would suggest making gtkspell support optional and add a conditional for gtk2/3 selection.
Comment 1 Daniele Forsi 2011-06-10 14:06:27 UTC
If you have patach ready please submit it, but you also need to replace libcanberra-gtk with libcanberra-gtk3.

We can support older versions by creating a gnome-2-32 branch but development will be only on the gtk+3 version in HEAD.

The gtk+3 symbols are pulled by the GNOME Bluetooth dependency so this could be the condition for gtk2/3 selection but I don't think it's worth the trouble.
Comment 2 Jan de Groot 2011-06-30 17:58:05 UTC
Created attachment 191046 [details] [review]
Port to gtk3
Comment 3 Daniele Forsi 2011-07-04 22:21:31 UTC
Comment on attachment 191046 [details] [review]
Port to gtk3

Reformatted commit message
Comment 4 Ladislav Michl 2017-12-02 21:55:12 UTC
Created attachment 364836 [details] [review]
ui: require gtk3

Require gtk3 for ui too.