After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652120 - Simplify ephy_string_commandline_args_to_uris()
Simplify ephy_string_commandline_args_to_uris()
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-08 15:06 UTC by Claudio Saavedra
Modified: 2011-06-08 16:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simplify ephy_string_commandline_args_to_uris() (1.96 KB, patch)
2011-06-08 15:06 UTC, Claudio Saavedra 		committed Details | Review

Description Claudio Saavedra 2011-06-08 15:06:57 UTC 
Apparently, this code was originally written before there was GIO and GFile.
Nowadays, it's hard to think of a reason why we would need to use realpath(3).

This patch simplifies the ephy_string_commandline_args_to_uris() method
by removing the redundant code and simply using g_file_query_exists() instead
of realpath().

This bug depends on the attachment 189475 [details] [review] in bug 652119.
Comment 1 Claudio Saavedra 2011-06-08 15:06:59 UTC 
Created attachment 189477 [details] [review]
Simplify ephy_string_commandline_args_to_uris()

No need to use realpath(3), we're in 2011 now.
Comment 2 Xan Lopez 2011-06-08 16:06:39 UTC 
Review of attachment 189477 [details] [review]:

Woot.

::: lib/ephy-string.c
@@ +528,2 @@
 		}
 		else {

While you are at it you can fix this weird thing, I guess. The style is wrong.
Comment 3 Claudio Saavedra 2011-06-08 16:14:40 UTC 
I guess I added that in patch in attachment 189475 [details] [review]. I'll fix it there.
Comment 4 Claudio Saavedra 2011-06-08 16:31:32 UTC 
Attachment 189477 [details] pushed as 490f0b5 - Simplify ephy_string_commandline_args_to_uris()