Bug 652050 - Add gnome_rr_output_get_edid_size()
Add gnome_rr_output_get_edid_size()
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
git master
Other All
: Normal enhancement
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
:
Depends on:
Blocks: 651626
  Show dependency tree
 
Reported: 2011-06-07 13:47 UTC by Richard Hughes
Modified: 2011-06-07 15:54 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
[patch] patch for review (2.38 KB, patch)
2011-06-07 13:47 UTC, Richard Hughes 		needs-work Details | Diff | Review
patch for review (3.41 KB, patch)
2011-06-07 15:47 UTC, Richard Hughes 		accepted-commit_now Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Richard Hughes 2011-06-07 13:47:53 UTC 
Created attachment 189401 [details] [review]
[patch] patch for review

It's wrong to assume that the EDID size is always 128 bytes if there are
extension blocks.

---

This functionality is required if we want to parse the EDID in any safe way.
Comment 1 Bastien Nocera 2011-06-07 15:36:40 UTC 
Review of attachment 189401 [details] [review]:

::: libgnome-desktop/gnome-rr.h
@@ +134,3 @@
 int             gnome_rr_output_get_height_mm      (GnomeRROutput         *output);
 const guint8 *  gnome_rr_output_get_edid_data      (GnomeRROutput         *output);
+gsize           gnome_rr_output_get_edid_size      (GnomeRROutput         *output);

Nope. Use:
const guint8 *  gnome_rr_output_get_edid_data      (GnomeRROutput         *output,
                                                    gsize                 *size);

And return the size (we can break the API, it's unstable).
Comment 2 Richard Hughes 2011-06-07 15:47:50 UTC 
Created attachment 189415 [details] [review]
patch for review

Something like this...
Comment 3 Bastien Nocera 2011-06-07 15:50:51 UTC 
Review of attachment 189415 [details] [review]:

Looks good.
Comment 4 Richard Hughes 2011-06-07 15:54:01 UTC 
Cool, thanks. I'll fix up any breakage in jhbuild as it pops up.
Note You need to log in before you can comment on or make changes to this bug.