Created attachment 189369 [details] [review]
disconnect "password-retrieved" signal before disposing widget

Hi, for a while I've been seeing a crash with empathy as follows:

 - one of my gtalk accounts has the wrong password
 - so when I start empathy, login fails of course
 - I get the little bar with "Authentication failed" in my main empathy window
 - but clicking on the "Edit Account" button launches empathy-accounts that crashes immediately in empathy_account_settings_get_string() (because settings is NULL)

I finally took some time to debug this.  What seems to happen is that when empathy-accounts gets started (in this case empathy spawns it as "/usr/bin/empathy-accounts --select-account=gabble/jabber/xxx..."), a settings widget gets created and as part of that the "password-retrieved" signal is hooked, and the underlying settings starts an asynchronous call to gnome keyring to get the password.

Then the code ends up in accounts_dialog_update_settings() which does the stuff near

  /* We have an account selected, destroy old settings and create a new
   * one for the account selected */

so the first account widget gets disposed before the gnome keyring call has finished.  As part of the dispose, the account widget does "priv->settings = NULL" and so when the "password-retrieved" signal finally comes in, we blow up.

The simplest fix seems to be to disconnect the password retrieved signal as part of the accounts widget dispose.  I've attached a patch that does this, which I've fixes the crash on my system.