After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651944 - Fails to build on GNU/Hurd
Fails to build on GNU/Hurd
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
0.7.x
Other GNU Hurd
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
: 651937 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-06-05 17:26 UTC by Pino Toscano
Modified: 2011-07-03 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
compile fix (444 bytes, patch)
2011-06-05 17:26 UTC, Pino Toscano 		none Details | Review

Description Pino Toscano 2011-06-05 17:26:35 UTC 
Created attachment 189273 [details] [review]
compile fix

d-conf 0.7.5 fails to build on GNU/Hurd (you can see [1] the failing build log from Debian's hurd-i386 architecture).
The problem is the <sys/mount.h> system include, which is not present in Hurd.
Looking at the statfs(2) man page, it would seem that statfs() is present in <sys/mount.h> on FreeBSD only, while in <sys/vfs.h> or <sys/statfs.h> in other systems.
The attached patch does that, i.e include <sys/param.h> and <sys/mount.h> on FreeBSD only, while <sys/statfs.h> and <sys/vfs.h> elsewhere.
It has been successfully tested on GNU/Hurd and GNU/Linux.

[1] https://buildd.debian.org/status/fetch.php?pkg=d-conf&arch=hurd-i386&ver=0.7.5-1&stamp=1305710859
Comment 1 Allison Karlitskaya (desrt) 2011-06-08 00:36:22 UTC 
*** Bug 651937 has been marked as a duplicate of this bug. ***
Comment 2 Allison Karlitskaya (desrt) 2011-07-03 15:33:32 UTC 
commit 7b99c368158db2f622c1bb01de4bdde62270c2d0
Author: Ryan Lortie <desrt@desrt.ca>
Date:   Sun Jul 3 17:31:12 2011 +0200

    Simplify 'shmdir' checks
    
    With XDG_RUNTIME_DIR, we no longer have to be frightened about NFS.
    That lets us remove the NFS checks that were causing build failures all
    over the place.