After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651936 - Install bash completion file as data file and not as executable shell script
Install bash completion file as data file and not as executable shell script
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
0.7.x
Other Linux
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-05 15:17 UTC by Michael Biebl
Modified: 2011-07-05 20:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Install bash completion as DATA and not SCRIPTS (846 bytes, patch)
2011-06-05 15:17 UTC, Michael Biebl 		none Details | Review
[PATCH] Use completion_DATA instead of completion_SCRIPTS in EXTRA_DIST (767 bytes, patch)
2011-07-03 16:54 UTC, Michael Biebl 		none Details | Review

Description Michael Biebl 2011-06-05 15:17:22 UTC 
Created attachment 189270 [details] [review]
Install bash completion as DATA and not SCRIPTS

The bash completion file is meant to be sourced and not executed
directly. As such it doesn't have a shebang.
Comment 1 Allison Karlitskaya (desrt) 2011-07-03 15:36:42 UTC 
You're right of course.  I've applied your fix.

The same problem applies to the completion files installed by glib (for GDBus and GSettings).  I'll fix those up too.

Thanks.
Comment 2 Michael Biebl 2011-07-03 16:54:11 UTC 
Created attachment 191188 [details] [review]
[PATCH] Use completion_DATA instead of completion_SCRIPTS in  EXTRA_DIST
Comment 3 Michael Biebl 2011-07-03 16:55:12 UTC 
(In reply to comment #2)
> Created an attachment (id=191188) [details] [review]
> [PATCH] Use completion_DATA instead of completion_SCRIPTS in  EXTRA_DIST

I forgot to change the EXTRA_DIST line.
Sorry for that.
Patch for this is attached.
Comment 4 Allison Karlitskaya (desrt) 2011-07-05 20:21:04 UTC 
Fixed up.  My fault for not reviewing properly.  Thanks.