After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651872 - Gtk.TreeModel.ref_node() and unref_node() should not be abstract
Gtk.TreeModel.ref_node() and unref_node() should not be abstract
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GTK+ GStreamer WebKitGTK+
0.12.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-04 20:42 UTC by Sébastien Wilmet
Modified: 2011-06-05 08:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sébastien Wilmet 2011-06-04 20:42:07 UTC 
The API about Gtk.TreeModel.ref_node() and unref_node() says:

> This is an optional method for models to implement. To be more specific, models may ignore this call as it exists primarily for performance reasons.

Moreover, if we look at the source code of Gtk.ListStore and Gtk.TreeStore, these methods are not present.

With the abstract keyword we have to implement them, even if empty. So the abstract keyword should be removed I think.
Comment 1 Luca Bruno 2011-06-05 08:00:29 UTC 
commit beda92a0501fc408f81986052506589c1654eead
Author: Luca Bruno <lucabru@src.gnome.org>
Date:   Sun Jun 5 09:59:21 2011 +0200

    gtk+-2.0, gtk+-3.0: Make TreeModel.ref_node and unref_node be virtual
    
    Fixes bug 651872.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.