After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651821 - Port PreferencesDialog to GtkBuilder
Port PreferencesDialog to GtkBuilder
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal normal
: 0.14.1
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks: 651820
 
 
Reported: 2011-06-03 22:31 UTC by Stéphane Maniaci
Modified: 2011-06-16 03:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port PreferencesDialog to GtkBuilder (15.48 KB, patch)
2011-06-03 22:31 UTC, Stéphane Maniaci 		none Details | Review
Port PreferencesDialog to GtkBuilder (15.58 KB, patch)
2011-06-06 07:39 UTC, Stéphane Maniaci 		none Details | Review

Description Stéphane Maniaci 2011-06-03 22:31:20 UTC 
Created attachment 189187 [details] [review]
Port PreferencesDialog to GtkBuilder

Here's the patch to port our prefs.py to GtkBuilder. This trims down a lot of code (_createUI() is 10 lines now...) and also allow consistent behaviour of the dialog.

Previously PreferencesDialog was a GladeWindow, which was a wrapper around GtkWindow. Now that's it a standard GtkDialog, it escapes on ESC key, shades the background app and is modal automatically. What else? :)

Patch based on master branch (not Thibault's GtkBuilder branch).
Comment 1 Thibault Saunier 2011-06-06 05:56:40 UTC 
That sounds good, could you please rebase it over the current master so I can actually review it plz ;)
Comment 2 Stéphane Maniaci 2011-06-06 07:39:28 UTC 
Created attachment 189301 [details] [review]
Port PreferencesDialog to GtkBuilder

New patch applied against master.
Comment 3 Thibault Saunier 2011-06-16 01:29:41 UTC 
commit d34a5e46435280f257b12f560462b906fd796c38
Author: Stéphane Maniaci <stephane.maniaci@gmail.com>
Date:   Mon Jun 6 00:36:14 2011 -0700

    Port PreferencesDialog to GtkBuilder