After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651782 - add d3dvideosink on windows
add d3dvideosink on windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 624486 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-06-03 13:42 UTC by Levente Farkas
Modified: 2011-06-26 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
d3d patch (224.50 KB, patch)
2011-06-03 13:42 UTC, Levente Farkas 		committed Details | Review
th old Makefile.in (19.06 KB, text/plain)
2011-06-03 13:43 UTC, Levente Farkas 		  Details
dx.hj patch (1.31 KB, patch)
2011-06-05 08:50 UTC, Levente Farkas 		committed Details | Review
lower directdrawsink's rank (624 bytes, patch)
2011-06-05 08:54 UTC, Levente Farkas 		committed Details | Review

Description Levente Farkas 2011-06-03 13:42:27 UTC 
Created attachment 189156 [details] [review]
d3d patch

i attached a patch from the ossbuild project with add a new (probably better) videosink on windows.
the question here is the sys/d3dvideosink/Makefile.in i'm not a autotool expert so i don't know which is the better (the one included in the d3d patch or the second file i attached).
Comment 1 Levente Farkas 2011-06-03 13:43:45 UTC 
Created attachment 189157 [details]
th old Makefile.in
Comment 2 David Schleef 2011-06-05 02:02:22 UTC 
commit 655e511a5c1704df907eaa62d6d9a6d32d2fd032
Author: David Schleef <ds@schleef.org>
Date:   Sat Jun 4 18:43:45 2011 -0700

    d3dvideosink: Add plugin
    
    Fixes #651782.  Patch from various authors, by way of ossbuild.
Comment 3 Levente Farkas 2011-06-05 08:50:44 UTC 
Created attachment 189259 [details] [review]
dx.hj patch

the original patch has some old bug please also apply this one
Comment 4 Levente Farkas 2011-06-05 08:54:27 UTC 
Created attachment 189260 [details] [review]
lower directdrawsink's rank

and if you alrady add d3dvideosink you can lower the rand of directdrawsink.
thanks
Comment 5 Tim-Philipp Müller 2011-06-05 16:48:25 UTC 
If you want to draw attention to further patches, you should re-open the bug, INCOMPLETE means a bug was closed because there wasn't sufficient information to do anything about it.
Comment 6 David Schleef 2011-06-05 20:58:46 UTC 
Note that I changed directdrawsink to SECONDARY, not MARGINAL.

(And I got --author right this time!  Ah, brainfarts.)

commit be60b7d0de1166622e0f77245b938107ca9b212f
Author: Levente Farkas <lfarkas@lfarkas.org>
Date:   Sun Jun 5 13:56:08 2011 -0700

    directdrawsink: lower rank to secondary
    
    Signed-off-by: David Schleef <ds@schleef.org>

commit be87d62fdefce4c5e4b61acc701bf248bf11955c
Author: Levente Farkas <lfarkas@lfarkas.org>
Date:   Sun Jun 5 13:38:46 2011 -0700

    d3dvideosink: compile fix
    
    Signed-off-by: David Schleef <ds@schleef.org>
Comment 7 Sebastian Dröge (slomo) 2011-06-26 12:41:04 UTC 
*** Bug 624486 has been marked as a duplicate of this bug. ***