After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651702 - don't hardcode the keyboard implementation name
don't hardcode the keyboard implementation name
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-02 12:46 UTC by Dan Winship
Modified: 2011-06-08 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use generic keyboard service name. (5.21 KB, patch)
2011-06-08 19:56 UTC, Eitan Isaacson
none Details | Review

Description Dan Winship 2011-06-02 12:46:01 UTC
Currently the caribou daemon launches a specific keyboard implementation. To make this work with the shell (where we need to have it use the shell's in-process keyboard rather than an out-of-process keyboard), it should do activation more generically:

    - daemon/main.py should activate a generic name like
      "org.gnome.Caribou.Keyboard" rather than "org.gnome.Caribou.Antler"

    - org.gnome.Caribou.Antler.service should list that generic name
      (thus becoming the default implementation of that service)

    - Caribou.KeyboardService should claim that generic name (in addition
      to an implementation-specific name?), with
      BusOwnerNameFlags.ALLOW_REPLACEMENT | BusOwnerNameFlags.REPLACE

    - Antler (not libcaribou) should exit if it loses the bus name

    - gnome-shell would then claim org.gnome.Caribou.Keyboard at startup.
      So if caribou was started while the shell was running, it would
      use the already-running shell keyboard. But if caribou was started
      in fallback mode, it would still end up launching antler via
      dbus activation just like it does now.
Comment 1 Eitan Isaacson 2011-06-08 19:56:28 UTC
Created attachment 189498 [details] [review]
Use generic keyboard service name.

- Have it replaceable by a service that is activated later.
- Have Antler quit if the generic name is acquired by a new service.
- Keep non-replaceable implementation specific name on bus.
Comment 2 Eitan Isaacson 2011-06-08 19:58:45 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.