After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651667 - GENERAL Style/Formatting Confusion
GENERAL Style/Formatting Confusion
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2011-06-01 22:40 UTC by Andreas J. Guelzow
Modified: 2011-06-04 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Tentative patch (5.73 KB, patch)
2011-06-03 14:32 UTC, Morten Welinder 		none Details | Review

Description Andreas J. Guelzow 2011-06-01 22:40:10 UTC 
Enter 1....10 in A1 to A10
Format A1 to A10 to scientific notation
Insert a new column A
Enter 1...10 in A1 to A10

Note: A1 to A10 are now also formatted in scientific notation

Select A1 to A10 and open format->cells->format
Note that the formatting is "Scientific", change it to general, okay

Note: A1 to A10 are still formatted in scientific notation.
Open format->cells->format and see that apparently the format wasn't changed to GENERAL.


Do we intend to have the meaning of GENERAL change?
Comment 1 Andreas J. Guelzow 2011-06-01 22:43:17 UTC 
Note that if you now insert another column A and enter 1..10 in A1:A10 then those are again show as 1...10 so GENERAL seems to work.

Changing the now cells B1:B10 to GENERAL still doesn't work though.
Comment 2 Morten Welinder 2011-06-02 11:59:49 UTC 
That would mean that the values have acquired a format which overrides
the cells' format.
Comment 3 Morten Welinder 2011-06-02 13:10:58 UTC 
Yup.  Value format.  I'm not sure why we even have those.

        <gnm:Cell Row="0" Col="0" ValueType="40" ValueFormat="0E+00">1</gnm:Cell>
        <gnm:Cell Row="0" Col="1" ValueType="40" ValueFormat="0E+00">1</gnm:Cell>
        <gnm:Cell Row="1" Col="0" ValueType="40" ValueFormat="0E+00">2</gnm:Cell>
        <gnm:Cell Row="1" Col="1" ValueType="40" ValueFormat="0E+00">2</gnm:Cell>
        <gnm:Cell Row="2" Col="0" ValueType="40" ValueFormat="0E+00">3</gnm:Cell>
        <gnm:Cell Row="2" Col="1" ValueType="40" ValueFormat="0E+00">3</gnm:Cell>
        <gnm:Cell Row="3" Col="0" ValueType="40" ValueFormat="0E+00">4</gnm:Cell>
        <gnm:Cell Row="3" Col="1" ValueType="40" ValueFormat="0E+00">4</gnm:Cell>
        <gnm:Cell Row="4" Col="0" ValueType="40" ValueFormat="0E+00">5</gnm:Cell>
        <gnm:Cell Row="4" Col="1" ValueType="40" ValueFormat="0E+00">5</gnm:Cell>
Comment 4 Morten Welinder 2011-06-03 14:32:43 UTC 
Created attachment 189160 [details] [review]
Tentative patch

This patch simplifies matters and fixes a few bugs in the process.
After this, we don't attach a value format unless it actually overrides
the cell format.

The patch touches a very fundamental function so we had better test it
well.
Comment 5 Andreas J. Guelzow 2011-06-04 01:51:12 UTC 
I have tried lots of things relating to formats  but haven't seen anything strange happening.
Comment 6 Morten Welinder 2011-06-04 15:09:10 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 7 Andreas J. Guelzow 2011-06-04 15:22:03 UTC 
It occurred to me that one place where value formats might be useful is in context with the HYPERLINK function: In Excel, the return value of any expression containing the HYPERLINK function has a hyperlink attached (the target obtained by evaluating the expression again but this time using the other argument of every HYPERLINK()0.