After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651602 - Network list mostly unusable with large number of VPN connections
Network list mostly unusable with large number of VPN connections
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-01 00:35 UTC by Gordon Messmer
Modified: 2011-06-08 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
NetworkMenu: only show 5 connections per device (4.02 KB, patch)
2011-06-02 14:25 UTC, Giovanni Campagna
committed Details | Review

Description Gordon Messmer 2011-06-01 00:35:28 UTC
With a large number of VPN connections present, the "more" button on the list of wireless networks does not work.

The first problem is that the VPN list doesn't collapse like the wireless network list does, so it flows off the end of the screen.  This makes it impossible to reach some of the VPN connections from the shell's list.

Because the VPN list already fills the screen, the "More" button on the list of wireless networks doesn't have room to expand its list.

Users will be unable to see the full extent of either list, and will have to use the "Network" control center applet for many of their network selections.
Comment 1 Giovanni Campagna 2011-06-02 14:25:26 UTC
Created attachment 189085 [details] [review]
NetworkMenu: only show 5 connections per device

If we have more than 5 (which can happen with VPN connections), place
them into a More... submenu, which also becomes scrollable if needed.
To protect from race conditions and ordering issues while reading
connections, sort them in alphabetic order when the timestamp is equal.
Comment 2 Dan Winship 2011-06-03 17:04:54 UTC
Comment on attachment 189085 [details] [review]
NetworkMenu: only show 5 connections per device

looks ok, but would it be possible to merge the wifi-specific More... handling in with the new generic More...?
Comment 3 Giovanni Campagna 2011-06-03 19:24:24 UTC
(In reply to comment #2)
> (From update of attachment 189085 [details] [review])
> looks ok, but would it be possible to merge the wifi-specific More... handling
> in with the new generic More...?

Not really. Wifi operates on dev._networks (many-to-many collection of access points and connections), whereas all the rest iterate dev._connections, and they have different semantics wrt automatic connections.
They share as much code as possible, I think.
Comment 4 Giovanni Campagna 2011-06-08 15:27:25 UTC
Attachment 189085 [details] pushed as 82648bc - NetworkMenu: only show 5 connections per device