GNOME Bugzilla – Bug 651564
[vorbisenc/theoraenc] Proxy downstream caps restrictions (e.g. resolution, channels, etc)
Last modified: 2012-03-23 17:28:39 UTC
See summary, currently both encoders don't do that. I guess the same applies for many other encoders, especially ones in other modules, too. x264enc and xvidenc are fixed though. Reason why we need this is that it allows to use the constraints of encodebin and in general allows better negotiation.
essentially this means that a getcaps function on the sinkpad needs to be implemented, getting the downstream peer caps and doing something useful with them (i.e. converting them to the upstream format) see x264enc/xvidenc for example
Also see bug #584599
Created attachment 189101 [details] [review] https://github.com/luisbg/gst-plugins-base/commit/2eb7d899ca56f3bdfd4de34ac5fcc003de2f939c patch (001/003)
theora: get sink caps info from downstream element pad meant that ^, instead of the url above
Created attachment 189102 [details] [review] theora: get sink caps info from downstream element pad patch 001/003
Created attachment 189103 [details] [review] theora: set the width/height/par on the srcpad caps patch 002/003
Created attachment 189105 [details] [review] theora: use fixed src cap pads patch 003/003
thanks for all the help Sebastian
All patches are marked as committed, is there any issue pending, or can this be closed ?
Luis, Sebastian, can this bug be closed ?
Yes Akhil, it can be closed. I don't have the priviledges to do so.