Created attachment 188916 [details] [review]
gstomx.conf: Fix multi-structure sink caps of omx_mpeg4dec

(In reply to comment #1)
> Created an attachment (id=188916) [details] [review]
> gstomx.conf: Fix multi-structure sink caps of omx_mpeg4dec

Wouldn't it be better to just have a sed or perl script to fix that automatically?

I don't know, do you have any advantage by having the multi-line caps in the conf.in but not in the conf?

(In reply to comment #3)
> I don't know, do you have any advantage by having the multi-line caps in the
> conf.in but not in the conf?

Easier to read and maintain.

Ok, are you going to do that? My sed/perl skills are not good enough to automatically convert the multi-line strings into a single line without spending a lot of time with learning perl

(In reply to comment #5)
> Ok, are you going to do that? My sed/perl skills are not good enough to
> automatically convert the multi-line strings into a single line without
> spending a lot of time with learning perl

I was hoping you would do that.

But anyway, this does it:

-       cat $^ | $(CPP) $(CFLAGS) $(libgstomx_la_CFLAGS) $(DEFAULT_INCLUDES) $(INCLUDES) - | grep -v "^#" | sed 's/\"\ *\"//g' >> $@
+       cat $^ | $(CPP) -P $(CFLAGS) $(libgstomx_la_CFLAGS) $(DEFAULT_INCLUDES) $(INCLUDES) - | sed 's/\"\ *\"//g' >> $@

No, this doesn't change anything for me

Actually it works, automake didn't regenerate Makefile{,.in} and I didn't notice. Please commit that change and my to other, somewhat related and trivial, changes from

http://cgit.collabora.com/git/user/slomo/gst-openmax.git/log/?h=pending

The commit messages explain the reasons for them, if there are still questions please ask.

Sorry for the delay.

I've pushed all your changes with a few cleanups.