GNOME Bugzilla – Bug 651483
String review
Last modified: 2011-06-25 15:53:41 UTC
Created attachment 188892 [details] String fixes Here is a patch to fix a few string errors I found. Also changes "..." to "…", not sure if this is a good idea in Python.
(In reply to comment #0) > Also changes "..." to "…", not sure if this is a good idea in Python. Sorry for butting in, but hopefully this will be of some help: It should be fine as long as the strings are marked as Unicode (i.e. “_(u'string')” instead of just “_('string')”), and the Python files are marked as being UTF-8 encoded (by putting “# -*- coding: utf-8 -*-” as the first line of the file). See http://git.gnome.org/browse/totem/commit/?id=42679707cd3281843ea2f347785ff52e682ff196 for an example of what's worked in Totem.
I'm not sure why we need to use the … character instead of actual dots? Also, while we're at it, for the string: "You do not have a GStreamer source element to handle the '%s' protocol" Maybe you could use: 'You do not have a GStreamer source element to handle the "%s" protocol' Could you also rebase your patch so that it applies cleanly onto master? Other than that, from the looks of it, it seems fine. Your attention to detail is appreciated :)
Created attachment 189781 [details] [review] v2 without ellipses Here's a rebased patch without ellipses. On hearing what would need to be done for it to work, I admit I sort of forgot about this patch. Anyway, all of the changes are from the en_GB translation.
A slightly modified version will be merged as part of my 0.14-localization-issues branch.
Fix committed to master as d81ab8bc6d58f0fa9950a3074ce614037616148e