After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651461 - e_book_backend_file_get_changes: Possible memory leak
e_book_backend_file_get_changes: Possible memory leak
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-05-30 11:18 UTC by Christophe Dumez
Modified: 2011-06-07 09:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.07 KB, patch)
2011-05-30 11:18 UTC, Christophe Dumez 		committed Details | Review

Description Christophe Dumez 2011-05-30 11:18:54 UTC 
Created attachment 188877 [details] [review]
Proposed patch

Currently, only the list elements were freed. The attached patch makes sure the GLists are freed too.
Comment 1 Matthew Barnes 2011-05-31 14:38:37 UTC 
Patch looks correct.  I had to double-check that the list content was getting freed, but it looks like it is.  This is a case where using GQueues instead of GLists would have been easier...

This code no longer exists on the master branch, but you can commit to the gnome-3-0 branch and backport if needed.
Comment 2 Patrick Ohly 2011-06-07 09:01:52 UTC 
Chris backported the fixes and I committed them to 2.32 and 3.0 branches:

d17323b4ca72ef45a1534a1fa3c49a1576f751fc e_book_backend_file_get_changes: Fix possible memory leak
c85a6bccc2412b357901386b671651a45fde74d4 e_book_backend_file_get_changes: Fix possible memory leak