After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651435 - e_name_western_reorder_asshole: Possible memory leak
e_name_western_reorder_asshole: Possible memory leak
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-05-30 07:43 UTC by Christophe Dumez
Modified: 2011-06-07 09:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (912 bytes, patch)
2011-05-30 07:43 UTC, Christophe Dumez 		committed Details | Review

Description Christophe Dumez 2011-05-30 07:43:30 UTC 
Created attachment 188860 [details] [review]
Proposed patch

In e_name_western_reorder_asshole(), the 'prefix' variable is not freed on early return. See attached patch.
Comment 1 Matthew Barnes 2011-05-31 13:35:46 UTC 
Interesting function name.  Anyway, yes indeed that's a potential leak.

Commit to master and work backwards as far back as you need to.
Comment 2 Patrick Ohly 2011-06-07 09:00:00 UTC 
Chris backported the fixes and I committed them to 2.32 and 3.0 branches:

79f2f930a9df17eb5268c72ae6a4970e7bf0818b e_name_western_reorder_asshole: Fix possible memory leak
a178de88aae840d0fede477e2585be346f2b43e4 e_name_western_reorder_asshole: Fix possible memory leak