After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651256 - configure fails for the poor sods who use dash as sh
configure fails for the poor sods who use dash as sh
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-05-27 14:19 UTC by Jussi Kukkonen
Modified: 2011-06-15 23:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Don't use bash string substitution in configure (982 bytes, patch)
2011-05-27 14:20 UTC, Jussi Kukkonen 		rejected Details | Review
build: Don't use bash string substitution in configure.ac (774 bytes, patch)
2011-06-01 15:45 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Jussi Kukkonen 2011-05-27 14:19:26 UTC 
Attaching a patch...
Comment 1 Jussi Kukkonen 2011-05-27 14:20:41 UTC 
Created attachment 188758 [details] [review]
build: Don't use bash string substitution in configure
Comment 2 Emmanuele Bassi (:ebassi) 2011-05-27 15:09:47 UTC 
Review of attachment 188758 [details] [review]:

my first reaction is: here's a nickel, kid; go get yourself a better shell. :-p

the second reaction is: this should work fine with non-bash shells:

  VARNAME=${VARNAME#*  }

so I'd accept a patch that modified the bashism, just not in the way you did it. :-)
Comment 3 Emmanuele Bassi (:ebassi) 2011-06-01 15:45:49 UTC 
Created attachment 189020 [details] [review]
build: Don't use bash string substitution in configure.ac

Use the shell-neutral version.
Comment 4 Emmanuele Bassi (:ebassi) 2011-06-01 15:46:16 UTC 
Attachment 189020 [details] pushed as cb321e0 - build: Don't use bash string substitution in configure.ac
Comment 5 Robert Bragg 2011-06-15 23:17:53 UTC 
Moving all bugs assigned to the Cogl component of the Clutter product to be under the general component of the new Cogl product.