After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651227 - Should filter out delivery report from pending messages
Should filter out delivery report from pending messages
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jasper St. Pierre (not reading bugmail)
gnome-shell-maint
Depends on:
Blocks: 644297
 
 
Reported: 2011-05-27 09:47 UTC by Guillaume Desmottes
Modified: 2011-06-01 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
skip delivery reports in pending messages (#651227) (1.35 KB, patch)
2011-05-27 09:48 UTC, Guillaume Desmottes 		accepted-commit_now Details | Review

Description Guillaume Desmottes 2011-05-27 09:47:29 UTC 
Since http://git.gnome.org/browse/gnome-shell/commit/?id=2244b6ff1b2233485a55c1a9de611da071df29c8 we ignore incoming messages which are delivery reports, which is cool. But we should filter out them from pending messages as well.
Comment 1 Guillaume Desmottes 2011-05-27 09:48:35 UTC 
Created attachment 188737 [details] [review]
skip delivery reports in pending messages (#651227)

We already ignore them in _messageReceived but have to ignore them as well
when displaying pending messages.
Comment 2 Guillaume Desmottes 2011-05-27 09:48:59 UTC 
Or http://cgit.collabora.com/git/user/cassidy/gnome-shell/log/?h=filter-delivery-report-651227 if you are more a Git person.
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-05-31 15:45:16 UTC 
Review of attachment 188737 [details] [review]:

My functional programming! Why isn't this the composition of "map" and "filter"!

Oh well, it's probably cleaner this way. LGTM.
Comment 4 Guillaume Desmottes 2011-06-01 08:23:25 UTC 
Merged to master; thanks.


commit 7b65735cc9f9158089614000438491694eb5ec25
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri May 27 10:52:08 2011 +0200

    skip delivery reports in pending messages (#651227)
    
    We already ignore them in _messageReceived but have to ignore them as well
    when displaying pending messages.


This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.